Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion #3719

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix bash completion #3719

merged 1 commit into from
May 15, 2020

Conversation

mb300sd
Copy link
Contributor

@mb300sd mb300sd commented May 10, 2020

At some point lightning-cli help defaulted to human readable format, the additional -H broke the bash completion.

lightning-cli -H help
help=command=autocleaninvoice [cycle_seconds] [expired_by]
category=plugin
description=Set up autoclean of expired invoices.
verbose=Perform cleanup every {cycle_seconds} (default 3600), or disable autoclean if 0. Clean up expired invoices that have expired for {expired_by} seconds (default 86400).
command=balance [unit]
category=plugin
description=List detailed onchain and channel balance information
verbose=List detailed onchain and channel balance information
command=channelstats
category=plugin
description=List detailed channel stats for local node
verbose=List detailed channel stats for local node
command=check command_to_check
category=utility
description=Don't run {command_to_check}, just verify parameters.
verbose=check command_to_check [parameters...]

@cdecker cdecker mentioned this pull request May 12, 2020
@rustyrussell
Copy link
Contributor

Hi! Yes, the help is actually a boutique format, not the same as -H.

Love this patch though: can you add a changelog line to your commit though? That way it gets highlighted for the next release, eg:

Changelog-Fixed: bash completion on lightning-cli now works again

Thanks!

At some point lightning-cli help defaulted to human readable format, the additional -H broke the bash completion.

Changelog-Fixed: bash completion on lightning-cli now works again
@mb300sd
Copy link
Contributor Author

mb300sd commented May 13, 2020

Done :)

@cdecker
Copy link
Member

cdecker commented May 15, 2020

ACK 287b771

@cdecker cdecker merged commit b6285ff into ElementsProject:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants