Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paymod: fix typo which can cause memory overrun. #3869

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Jul 23, 2020

Split out from #3866 since it was unrelated and needs to go in independently.

Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-None
Closes #3866

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 68d8c5d

@@ -1756,7 +1756,7 @@ static bool routehint_excluded(struct payment *p,
* are suggesting we use it the other way. Very unlikely though! */
for (size_t i = 0; i < tal_count(routehint); i++) {
const struct route_info *r = &routehint[i];
for (size_t j=0; tal_count(nodes); j++)
for (size_t j = 0; j < tal_count(nodes); j++)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuuuuuuuugh

@cdecker cdecker merged commit 497b18b into master Jul 23, 2020
@rustyrussell rustyrussell deleted the route-mem-overrun branch August 15, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants