Repro builds #4021
Merged
Repro builds #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
Sep 9, 2020
Will do 👍 |
The template was using the version with the `v` prefix, whereas the repro-build script is searching for the version without the prefix
Changelog-Added: New reproducible build system now uses docker: try it at home with `doc/REPRODUCIBLE.md`!
cdecker
force-pushed
the
repro-builds
branch
from
eace110
to
3167bbf
Compare
rustyrussell
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing we have though is the Fedora build which is included in the
SHA256SUMSfile but is not built reproducibly (yet), so we should likely not list it in the manifest at all, otherwise we might get complaints that the hashes do not match. What do you think @rustyrussell?The huge advantage we have with docker is that this can all be automated now, and we can setup a nightly build machine that can feed into a repository.