db: Fix size mismatch on postgres in a migration #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what is happening, but this fix works and saved my life. |
rustyrussell
force-pushed
the
issue-4050
branch
from
bdab7fe
to
6ae9899
Compare
|
Pushed regen fix |
Changelog-Fixed: db: Fixed a broken migration on postgres DBs that had really old channels.
rustyrussell
force-pushed
the
issue-4050
branch
from
6ae9899
to
c573705
Compare
It's a minor detail that we are checking for the postgres DB backend: postgres has well-defined datatypes, each with a given size on disk. This is different from sqlite3 which aliases all integer types to it's single, variable sized, int type. To protect against truncation we check that we access fields of a given size only with the matching accessors. In this case one slipped through: we were reading a u64 with an accessory for s32, which doesn't have any impact in this case, but better be safe than sorry 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4050