Dual-funding over multifundchannel fixups, etc #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/df-mfc-fixes
branch
2 times, most recently
from
6842565
to
c76b6d2
Compare
Since fundchannel/multifundchannel now handles v2 opens, we use that instead of this hacked together plugin.
We have a required minimum witness weight for dual funded opens.
Needed for v2 of channel opens, where the minimum weight is 110; a 'simple utxo' (sig + key) weighs in at 107, so we a need a way to establish a floor for this case. Changelog-Added: JSON-RPC: fundpsbt/utxopsbt have new param, `min_witness_utxo`, which sets a floor for the weight calculation of an added input
We'll use it for figuring out whether or not to set a utxo witness minimum, which comes much before we were setting this field. Now we set the protocol as soon as we can reasonably deduce it.
We only need a bumped up input weight if we're talking to nodes that require v2.
niftynei
force-pushed
the
nifty/df-mfc-fixes
branch
from
c76b6d2
to
5b8ea32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts at 60c8901. Includes commits that are in #4210.
This PR does a few things
dual_openwires todualopend, as this conforms to the other daemon naming scheme.multifundchannelnow handles itopt_dual_fundparticipants.