invoice: make invoice_payment hook a multi-user hook. #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
reviewed
Nov 25, 2020
lightningd/invoice.c
Outdated
| @@ -393,6 +397,10 @@ void invoice_try_pay(struct lightningd *ld, | |||
| payload->set = set; | |||
| tal_add_destructor2(set, invoice_payload_remove_set, payload); | |||
|
|
|||
| /* We notify here to benefit from the payload and because the hook callback is | |||
There was a problem hiding this comment.
Comment no longer quite matches? This is not the hook callback anymore, right?
ZmnSCPxj
approved these changes
Dec 1, 2020
We register on it for offers, and without this nobody else can. Changelog-Changed: plugins: more than one plugin can now register invoice_payment hook. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
invoice_payment-chain
branch
from
2dc52db
to
86f4ad3
Compare
|
Trivial fold-fixup-and-rebase-on-master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We register on it for offers, and without this nobody else can.
Changelog-Changed: plugins: more than one plugin can now register invoice_payment hook.