common: change default network to mainnet #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsarenik
force-pushed
the
jsn/network
branch
from
fcf72f0
to
d268646
Compare
jsarenik
changed the title
jsarenik
force-pushed
the
jsn/network
branch
from
d268646
to
44e2eb4
Compare
|
The whole idea of this patch was changed after feed-back from @rustyrussell . Now it is removing all the logic that would detect if the directory |
|
Note: original patch which introduced this function which checks for the smell was 36c517b and it also brought following include files: +#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>Would it be safe to remove all of these? @rustyrussell |
jsarenik
force-pushed
the
jsn/network
branch
from
44e2eb4
to
c419ba6
Compare
jsarenik
changed the title
Changelog-changed: Default network on both new and old installs is now bitcoin. The warning "default network changing in 2020" was removed. Reverts 36c517b Fixes ElementsProject#4159
jsarenik
force-pushed
the
jsn/network
branch
from
c419ba6
to
bf19dc6
Compare
|
Needs a changelog entry, otherwise excellent 👍 ACK bf19dc6 |
|
@cdecker See the commit itself. There is currently this changelog entry: |
jsarenik
changed the title
jsarenik
changed the title
|
I see, @bitcoin-bot must have been slow picking it up and the check was marked as pending. All good to go then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-changed: Default network on both new and old
installs is now bitcoin. The warning "default network
changing in 2020" was removed.
Reverts 36c517b (except the comment)
Fixes #4159