mfc: bug fixes for v2 opens #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/df-rbf-mfc
branch
from
5a73c72
to
09bf465
Compare
niftynei
force-pushed
the
nifty/df-rbf-mfc
branch
from
09bf465
to
9254326
Compare
|
Looking good, but need to settle #4295 first. |
rustyrussell
approved these changes
Jan 6, 2021
Ideally we'd 'cure' the error and re-attempt, except that if this was a bitcoin-backend 'failure to broadcast' then it really needs user intervention to figure out what's wrong -- it's possible that the peer successfully broadcast the transaction
We only want to attempt to unreserve inputs that are ours (otherwise we log a broken error)
Since we round down in `amount_tx_fee`, find the change fee as the difference between what we've already paid and what the combined/total fee would be if the change weight were also added.
This will cause blow ups for v2 multifundchannel attempts with failures, but allows us to return the expected errors for single-shot fundchannel attempts. Error handling is coming, i promise
cdecker
force-pushed
the
nifty/df-rbf-mfc
branch
from
9254326
to
e1938cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few problems found while running tests against the v2 open pathways.
Update: this now depends on #4295, as we use the
take()semantic forjson_add_psbtin this patchset. First 'new commit' is6cb23fbChangelog-None.