Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post v0.10 cleanups #4465

Merged
merged 13 commits into from
Apr 7, 2021
Merged

Post v0.10 cleanups #4465

merged 13 commits into from
Apr 7, 2021

Commits on Apr 5, 2021

  1. Makefile: update to latest BOLT versions. 

    The main change which affects us is that 2016 blocks to forget a channel
is a fixed number in the spec; we make this clear by renaming the
(developer-only) max_funding_unconfirmed to dev_max_funding_unconfirmed
and making it compile DEVELOPER only.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    a885616 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. doc: remove suffix for included-in-master BOLTs. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    7d3589b View commit details
    Browse the repository at this point in the history

  2. Makefile: make it easier to check bolt text. 

    Instead of "only check suffix quotes when EXPERIMENTAL_FEATURES", make
it so we only check suffix quotes if you override BOLTVERSION on the
cmdline.

Before this, "make check-source-bolt" was effectively a NOOP with
--enable-experimental-features.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d336b1d View commit details
    Browse the repository at this point in the history

  3. close: activate notifications even with deprecated-apis. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: JSON-RPC: `close` now always returns notifications on delays.
    @rustyrussell
    rustyrussell committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    657080e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. pyln: remove deprecated close variant. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: pyln: removed deprecated close `force` variant.
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3f547eb View commit details
    Browse the repository at this point in the history

  2. pyln: remove deprecated pay/sendpay variants. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: pyln: removed deprecated pay/sendpay `description` arg.
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    64fd3ff View commit details
    Browse the repository at this point in the history

  3. pyln: remove deprecated fundchannel/fundchannel_start variants. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: pyln: removed deprecated fundchannel/fundchannel_start `satoshi` arg.
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    1a627aa View commit details
    Browse the repository at this point in the history

  4. devtools: add experimental section. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    93abbd3 View commit details
    Browse the repository at this point in the history

  5. chaintopology: remove deprecated urgent/normal/slow feerate display. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    15b7018 View commit details
    Browse the repository at this point in the history

  6. lightningd: remove unused original_directory field. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    248238e View commit details
    Browse the repository at this point in the history

  7. plugin: always send allow-deprecated-apis in getmanifest. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: plugins: we now always send `allow-deprecated-apis` in getmanifest.
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    1cfccf9 View commit details
    Browse the repository at this point in the history

  8. newaddr: don't include "address" field. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: JSON-RPC: `newaddr` no longer includes `address` field (deprecated in 0.7.1)
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    aa9786e View commit details
    Browse the repository at this point in the history

  9. plugins: remove now-unused single-hook infrastructure. 

    Should have really let @mschmook do this, as he did all the work to
make it possible!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    d36565f View commit details
    Browse the repository at this point in the history