plugins/bcli: strip trailing whitespace appropriately #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
May 1, 2021
plugins/bcli.c
Outdated
| bcli->output[bcli->output_bytes-1] = 0x00; | ||
| /* Strip trailing whitespace and steal onto the stash. */ | ||
| size_t striplen = bcli->output_bytes; | ||
| while (isspace(bcli->output[striplen-1])) |
There was a problem hiding this comment.
We have a cisspace helper which is sightly better here, BTW.
Can we extract this into a "static void strip_trailing_whitespace(char *str, size_t len)"
which also makes sure it doesn't underflow if it's all whitespace?
Thanks!
nalinbhardwaj
force-pushed
the
whitespace-bcli
branch
2 times, most recently
from
7f2d754
to
7ca3a37
Compare
Changelog-Fixed: Handle windows-style newlines and other trailing whitespaces correctly in bitcoin-cli interface
nalinbhardwaj
force-pushed
the
whitespace-bcli
branch
from
7ca3a37
to
bd59929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4001