connectd: allow out-of-bounds fees unless they're actually getting *worse* #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orse*. Pointed out by @fiatjaf, and indeed it happened to me as well; a peer with a high feerate reconnects and sends a similar (but now ludicrous) feerate, and we get upset: ``` $ lightning-cli listpeers 039c73f53daad1050a6a72afb5353a2152f3152ee17168cd0ab28c2cb3e0050e36 { "peers": [ { "id": "039c73f53daad1050a6a72afb5353a2152f3152ee17168cd0ab28c2cb3e0050e36", "connected": false, "channels": [ { "state": "CHANNELD_NORMAL", "scratch_txid": "d796aa9c44920cc7169cdb61e36437bf180cedaec44103a69591ce2baac9b1d9", "last_tx_fee": "14329000msat", "last_tx_fee_msat": "14329000msat", "feerate": { "perkw": 19791, "perkb": 79164 }, ``` Then in the logs: ``` 2021-07-23T19:34:56.227Z DEBUG 039c73f53daad1050a6a72afb5353a2152f3152ee17168cd0ab28c2cb3e0050e36-channeld-chan#39381: billboard perm: update_fee 17055 outside range 253-7210 ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
fee
protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by @fiatjaf, and indeed it happened to me as well; a peer with a high feerate reconnects and sends a similar (but now ludicrous) feerate, and we get upset:
Then in the logs:
Signed-off-by: Rusty Russell rusty@rustcorp.com.au