pytest: restore gossip advertizement tests for default port. #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
requested changes
Dec 6, 2021
tests/test_gossip.py
Outdated
Comment on lines
1040
to
1043
| {'type': 'ipv4', 'address': '127.0.0.1', 'port': 19846}, | ||
| {'type': 'ipv6', 'address': '::', 'port': 3}, | ||
| {'type': 'ipv6', 'address': '::', 'port': 19846}, | ||
| {'type': 'torv3', 'address': 'vww6ybal4bd7szmgncyruucpgfkqahzddi37ktceo3ah7ngmcopnpyyd.onion', 'port': 19846}, |
There was a problem hiding this comment.
In the case of Elements this test will fail.
We need somethings like if 19846 l1.info["network"] == "testnet" else 2xxx
|
Concept ACK. Apologies for removing those lines @rustyrussell. |
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
restore-default-port-tests
branch
from
1c9aff0
to
08f3b16
Compare
|
Trivial rebase, and fix for elements default port. Ack 08f3b16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4900 which I've now merged.
Changelog-None