Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for DocFx extended file inclusion links #58

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mtirionMSFT
Copy link
Collaborator

@mtirionMSFT mtirionMSFT commented Aug 20, 2024

DocFx defines extension to include markdown files or code from external files. For details see https://dotnet.github.io/docfx/docs/markdown.html. These references are now supported by the DocLinkChecker. The referenced file is validated, but optional parameters to the link (including name links) are not validated. This fixes issues #29 and #51.

Copy link
Owner

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@mtirionMSFT mtirionMSFT merged commit c7ec3de into main Aug 21, 2024
@mtirionMSFT mtirionMSFT deleted the mtirion/29-fix-doclinkchecker-inclusion-links branch August 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants