added banana_log #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnnik
reviewed
May 24, 2021
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "variants": { | |||
There was a problem hiding this comment.
Multiple variants of the log because you can rotate it
nnnik
approved these changes
May 24, 2021
| public static final Item BANANA_ITEM = new Item(new Item.Settings().group(ItemGroup.MISC)); | ||
|
|
||
| public static final Block BANANA_LEAVES = new Block(FabricBlockSettings.of(Material.LEAVES).strength(2.0f)); | ||
| public static final Block BANANA_LOG = new Block(FabricBlockSettings.of(Material.WOOD).strength(2.0f)); | ||
| public static final Block BANANA_LOG = new PillarBlock(FabricBlockSettings.of(Material.WOOD).strength(2.0f)); |
There was a problem hiding this comment.
PillarBlock because logs are pillars according to Minecraft
There was a problem hiding this comment.
Currently missing code to assign different map colors depending on rotation
notNLS
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.