Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[faiss v1.7.1] Added high-level IVFFlatIndex impl #17

Merged
merged 7 commits into from
Jun 3, 2021
Merged

[faiss v1.7.1] Added high-level IVFFlatIndex impl #17

merged 7 commits into from
Jun 3, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented Mar 28, 2021 •
edited
Loading

bindings.rs is from not released API.

@Enet4 Enet4 self-requested a review March 28, 2021 21:16
@ava57r
Copy link
Collaborator Author

ava57r commented Mar 29, 2021

#13

ava57r
ava57r commented Apr 15, 2021
View reviewed changes
src/index/ivf_flat.rs Outdated Show resolved Hide resolved
@ava57r
Copy link
Collaborator Author

ava57r commented Apr 15, 2021

facebookresearch/faiss#1827

@ava57r ava57r changed the title Added high-level IVFFlatIndex impl [faiss not released] Added high-level IVFFlatIndex impl Apr 21, 2021
@ava57r ava57r changed the title [faiss not released] Added high-level IVFFlatIndex impl [faiss unreleased] Added high-level IVFFlatIndex impl Apr 22, 2021
@ava57r
Add setters, getters for IVFFlatIndexImpl
690a246 
Add:
- nprobe
- own_fields
@ava57r
Copy link
Collaborator Author

ava57r commented May 6, 2021

PR facebookresearch/faiss#1787 merged

@ava57r
Add some getters for IVFFlatIndexImpl
2f6a7b2 
Add:
- nlist
- train_type

sync c_api from PR faiss 1787
@ava57r
Copy link
Collaborator Author

ava57r commented May 6, 2021

PR facebookresearch/faiss#1764 merged

@ava57r
Copy link
Collaborator Author

ava57r commented May 7, 2021

I finished.
You can review it

@ava57r ava57r changed the title [faiss unreleased] Added high-level IVFFlatIndex impl [faiss v1.7.1] Added high-level IVFFlatIndex impl May 31, 2021
Enet4
Enet4 reviewed Jun 1, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be in great condition to release a new version of faiss-rs once these are merged. :)

I will try to review them all within the next few weeks.

src/index/ivf_flat.rs Outdated Show resolved Hide resolved
src/index/ivf_flat.rs Outdated Show resolved Hide resolved
Enet4
Enet4 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, thanks!

@Enet4 Enet4 merged commit b9f95ea into Enet4:master Jun 3, 2021
@ava57r ava57r deleted the ivf branch June 3, 2021 16:21
@ava57r ava57r mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ava57r @Enet4