Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to gen_bindings utils c_api dir #54

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented May 15, 2022

No description provided.

@ava57r ava57r requested a review from Enet4 May 17, 2022 06:00
@Enet4
Copy link
Owner

Enet4 commented May 18, 2022

Well, we can go on with these changes, but I'd still wonder whether they were supposed to be used by consumers of the library. Are there any functions introduced here which would be important to call directly?

@ava57r
Copy link
Collaborator Author

ava57r commented May 27, 2022

I agree. Users will use hardly ever these functions.

@ava57r ava57r closed this Jun 8, 2022
@ava57r ava57r reopened this Nov 28, 2022
@ava57r
Copy link
Collaborator Author

ava57r commented Nov 28, 2022

Hello

If user uses InnerProduct
It needs to use normalize* fn

documentation
https://github.com/facebookresearch/faiss/wiki/MetricType-and-distances#metric_inner_product

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Thank you @ava57r.

@Enet4 Enet4 merged commit 8d40fb9 into Enet4:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants