Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDPT debug #4

Merged
merged 5 commits into from
Mar 16, 2023
Merged

BDPT debug #4

merged 5 commits into from
Mar 16, 2023

Conversation

Enigmatisms
Copy link
Owner

BDPT bug fix:

  • Specular surfaces being too dark: failure in updating vertex is not fixed.
  • Fresnel blend PDF calculation is corrected.
  • MIS weight degenerated vertex tagging and related path connection strategies fixed
  • Tested with multiple scenes.
  • Typo Frensel is corrected (to Fresnel)... interesting...

@Enigmatisms Enigmatisms self-assigned this Mar 16, 2023
@Enigmatisms Enigmatisms added the fix Bug fix pull request label Mar 16, 2023
raven-sera
raven-sera approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@raven-sera raven-sera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Enigmatisms Enigmatisms merged commit 82bb9fa into master Mar 16, 2023
@Enigmatisms
Copy link
Owner Author

BDPT bug fix version merged. Transient rendering to be done.

@Enigmatisms Enigmatisms deleted the bdpt_debug branch March 16, 2023 16:04
@Enigmatisms Enigmatisms mentioned this pull request Mar 16, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raven-sera raven-sera raven-sera approved these changes

Assignees

@Enigmatisms Enigmatisms

Labels
fix Bug fix pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enigmatisms @raven-sera