Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add porosity of snow and water ice #923 #1341

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Add porosity of snow and water ice #923 #1341

merged 2 commits into from
Aug 15, 2022

Conversation

kaiiam
Copy link
Contributor

@kaiiam kaiiam commented Aug 14, 2022

Address #923 adding porosity of snow and water ice to EA design pattern. I think we'll have the large diff issue as I added this on a mac, and the presumably the last useage was on a PC, so we'll get the issue of the line endings changing the whole file instead of just the 2 lines I added. @cmungall was annoyed about this in the past.

@kaiiam kaiiam requested a review from pbuttigieg August 14, 2022 11:32
@kaiiam
Copy link
Contributor Author

kaiiam commented Aug 14, 2022

See OBI keeping-things-tidy for how they deal with this issue. Perhaps worth having if the PC/Mac line ending caused diffs are a problem for us.

Also Previously when I had used this pattern I used my own ID range (not 0 padded) for the IDs, but when @cmungall set this up he gave it an id range which I guess is the right way to use IDs for this pattern, so I picked up at the next one e.g. ENVO:09200034 for this PR.

Datatype: idrange:7

    Annotations:
        allocatedto: "ENVO-P, E-A"

    EquivalentTo:
        xsd:integer[>= 9200000 , <= 9299999]

@pbuttigieg
Copy link
Member

We default to UNIX line endings now - one of our docs should be a style guide for these concerns - thanks for spotting @kaiiam

Copy link
Member

@pbuttigieg pbuttigieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - would you mind rebuilding the OWL module so the classes are available in the editors' file ?

@pbuttigieg
Copy link
Member

Looks good - would you mind rebuilding the OWL module so the classes are available in the editors' file ?

@kaiiam built and pushed.

@pbuttigieg pbuttigieg dismissed their stale review August 15, 2022 13:20

Issue resolved

@pbuttigieg pbuttigieg merged commit 0e8765a into master Aug 15, 2022
@pbuttigieg pbuttigieg deleted the issue-923 branch August 15, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants