Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krishna to issue 363 #1354

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Krishna to issue 363 #1354

merged 9 commits into from
Aug 17, 2022

Conversation

pbuttigieg
Copy link
Member

Closes #1261

@pbuttigieg pbuttigieg self-assigned this Aug 17, 2022
@pbuttigieg
Copy link
Member Author

pbuttigieg commented Aug 17, 2022

Content review:

Both of these are dubiously placed under PATO:electromagnetic (EM) radiation quality defined as:

A physical quality that inheres in an bearer by virtue of how that bearer interacts with electromagnetic radiation.

Is the flux or its density interacting with EM radiation?

The subclass axioms were built as if they're equivalence axioms. These will be changed substantially.

  • photosynthetic photon flux - now a flux.
  • photosynthetic photon flux density - This can't be put under PATO:mass density as photons don't have mass in the regular sense. The definition reads more like a rate of receiving quanta of PAR on a surface. Thus represented this as a rate associated with a new class for irradiation of a surface with PAR. This is likely to need domain expert + ontologist revision in the future.

I created a stub hierarchy for irradiation, which should be expanded if it holds.

@pbuttigieg pbuttigieg merged commit 8364aa3 into master Aug 17, 2022
@pbuttigieg pbuttigieg deleted the KrishnaTO-issue-363 branch August 17, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants