Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periphytic biofilm subclasses #1472

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Jan 2, 2024

No description provided.

@turbomam
Copy link
Contributor Author

turbomam commented Jan 2, 2024

I copied and pasted the definition from the parent class. Unnecessary duplication?

I haven't added any axioms/logical definitions

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but there is a slight technical issue. For the rest of ENVO we are following norms in GO, CL, Uberon, etc where we place definition source as an axiom annotation on the definition. There may be an issue with the robot template configuration. I'll make a separate issue

@@ -44939,6 +44944,36 @@ AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03605000>
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03605000> "periphytic biofilm"@en)
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03605000> <http://purl.obolibrary.org/obo/ENVO_01000156>)

# Class: <http://purl.obolibrary.org/obo/ENVO_03605001> (epilithon)

AnnotationAssertion(Annotation(<http://purl.obolibrary.org/obo/IAO_0000119> "NEON.DOC.003044, revision E, title AOS Protocol and Procedure: AMC – Aquatic Microbial Sampling in https://data.neonscience.org/documents/10179/1883159/NEON.DOC.003044vE/05ca8fcc-33ba-a5b2-0e93-8f4001f38c37") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03605001> "Periphyton colonizing rock substrata")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't how we do definition sources in the rest of envo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't how we do definition sources in the rest of envo

Isn't that what I did?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants