Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of rules for scalar and non-differentiable functions #90

Merged
merged 75 commits into from
Jun 21, 2024

Conversation

mofeing
Copy link
Collaborator

@mofeing mofeing commented Jun 1, 2024

To do

  • Register StableHLO dialect when using CHLO dialect
  • Fix tests on complex data (specially reverse diff)
    • stablehlo.complex
    • chlo.conj
    • stablehlo.einsum
    • stablehlo.dot_general

src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
src/enzyme_ad/jax/Implementations/HLODerivatives.td Outdated Show resolved Hide resolved
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but add some tests?

@mofeing mofeing changed the title Add a bunch rules for scalar and non-differentiable functions Add a bunch of rules for scalar and non-differentiable functions Jun 20, 2024
@mofeing mofeing merged commit deb70f0 into main Jun 21, 2024
5 of 6 checks passed
@mofeing mofeing deleted the scalar-diffs branch June 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants