Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run register_llvm_rules in a module where optimizations are disabled #1305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

run register_llvm_rules in a module where optimizations are disabled #1305

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

fixes #776

@vchuravy vchuravy self-assigned this Feb 23, 2024
wsmoses
wsmoses reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am worried about this as these runtime functions make up a non negligible part of the adjoint generation runtime

@vchuravy
Copy link
Member Author

I still need to confirm, but iirc this should only apply to the ccallable thunk.

@vchuravy vchuravy added this to the release-0.12 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@vchuravy vchuravy

Labels
None yet
Projects
None yet
Milestone
release-0.12
Development

Successfully merging this pull request may close these issues.

Something invalidating Enzyme.__init__ causes a heavy package load time penalty
3 participants
@vchuravy @wsmoses @KristofferC