Explicitly annotate non-person etymology #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting gender to '-' instead of null when there is an etymology, but person==False, allows to render it differently from completely missing etymology.
|
@jbelien What do you think about this? |
I didn't have time to look into yet ; I'll try to do that in the next few days. |
|
@jbelien Just a friendly ping :) Let me know if there is any way I can help to move this forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EqualStreetNames/equalstreetnames#618. Setting gender to
'-'instead ofnullwhen there is an etymology, butperson==False, allows to render it differently from completely missing etymology (here just a subtle difference in line width).See these screenshots of one street with person etymology, one with non-person etymology, one without etymology.
NB: I also changed the dark mode colours for this screenshot because the current
unknowncolour is almost the same as the street colour in the map layer, not allowing to see differences in line width: eginhard/esn-module-website@78df489