Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reloading of RPKs if changed on disk #58

Closed
mistafunk opened this issue Dec 20, 2017 · 6 comments
Closed

support reloading of RPKs if changed on disk #58

mistafunk opened this issue Dec 20, 2017 · 6 comments
Assignees

Comments

@mistafunk
Copy link
Collaborator

mistafunk commented Dec 20, 2017

support reloading RPKs if they have been re-exported from CE while Houdini is running
additionally: prevent resolveMap->getX crashes if RPK keeps name but e.g. the cgb file inside are renamed

@mistafunk mistafunk added this to the v0.9 milestone Dec 21, 2017
@mistafunk mistafunk modified the milestones: v0.9, v1.0 Jan 4, 2018
@MattB3D
Copy link

MattB3D commented Jan 7, 2018

My thoughts:
1: Reloading at Houdini restart (works)
2: Reloading atfter browsing for one (works)
3: Reload RPK button (would be nice!)

I'm not sure if we need automatic change detection live in Houdini .. I'd skip that, as typically the Houdini artist is probably the same person that just edited the RPK.

@mistafunk mistafunk modified the milestones: v1.0, v1.1 (complete occlusion support) Jan 18, 2018
@mistafunk mistafunk self-assigned this Jan 27, 2018
@mistafunk
Copy link
Collaborator Author

the plan is to automatically reload RPKs if they change on disk (and update the cache as well), i.e. no reload button

mistafunk added a commit that referenced this issue Mar 3, 2018
mistafunk added a commit that referenced this issue Mar 3, 2018
the RPK change detection can be triggered by toggling a pldAssign parameter or by clicking on the parameter dropdowns of start rule, style or rule file.
@mistafunk
Copy link
Collaborator Author

mistafunk commented Mar 3, 2018

implemented RPK reloading based on file modification time stamp (still on the branch). currently, the reload and recook is only triggered if a pldAssign parameter is changed (or if a parameter dropdown is opened).

still pondering if we need an actual reload button...
also, we could install actual file listener which would reload (maybe even recook) fully automatically (but might be undesired for heavy scenes).

mistafunk added a commit that referenced this issue Mar 3, 2018
the RPK change detection can be triggered by toggling a pldAssign parameter or by clicking on the parameter dropdowns of start rule, style or rule file.
mistafunk added a commit that referenced this issue Mar 3, 2018
* allowing the pldAssign params to have values other than in the dropdowns (easier to debug the values when the RPK changes)
* the RPK change detection can be triggered by toggling a pldAssign parameter or by clicking on the parameter dropdowns of start rule, style or rule file.
@mistafunk
Copy link
Collaborator Author

mistafunk commented Mar 3, 2018

another open design issue: currently, choosing an RPK (or reloading it) resets the other three main params (start rule, rule file, style). is that wise? on the other hand, one could ensure these three values with an "attribute create" node before pldGenerate...

@mistafunk mistafunk changed the title automatically reload RPKs if changed on disk support reloading of RPKs if changed on disk Mar 3, 2018
@mistafunk
Copy link
Collaborator Author

renamed issue to deal with the actual reloading of RPKs... let's deal with automatic reloading in a separate issue

@mistafunk
Copy link
Collaborator Author

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants