-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CE-6909: functional review #44
Conversation
… when creating materials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two additional issues - please investigate. if not related to this PR, please create separate issues:
- missing opacity maps on the vegetation (favela example):
- error log entries from MCHECK in PRT console when creating arnold materials on favela example:
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:156: (kInvalidParameter): Argument is a NULL pointer (code 3)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:158: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:156: (kInvalidParameter): Argument is a NULL pointer (code 3)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:158: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & ready for merge.
please create an issue regarding the $shaderNode variable scoping (to avoid the warning)
created issue #46 for the variable shadowing |
address issues found in functional review for PR #25