Build: Fix GitHub Actions out-of-memory issues #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were at least two (potentially more that were fixed by Loom 1.2 -> 1.3 update) issues that are fixed in this commit: 1. `~` does not expand inside `"`, unlike regular variables. As such the maximum heap size wasn't actually applied and instead Gradle was free to consume all the memory in the VM, eventually killing the actions runner, resulting in fairly unhelpful failure messages. 2. A workaround for the BuildSharedServiceManager issue has been applied in Essential Loom 1.3.12. With that, it now easily builds in a single pass.
caoimhebyrne
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were at least two (potentially more that were fixed by Loom 1.2 -> 1.3 update) issues that are fixed in this commit:
~does not expand inside", unlike regular variables. As such the maximum heap size wasn't actually applied and instead Gradle was free to consume all the memory in the VM, eventually killing the actions runner, resulting in fairly unhelpful failure messages.