Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiply support to <1.14 #71

Closed
wants to merge 1 commit into from
Closed

Conversation

Deftu
Copy link

@Deftu Deftu commented May 20, 2024

After some digging, I've found that mul does exist in the older versions. Not sure as to why it was commented out here, please let me know if I'm mistaken here.

After some digging, I've found that `mul` does exist in the older versions. Not sure as to why it was commented out here, please let me know if I'm mistaken here.
@Johni0702
Copy link
Collaborator

Not sure as to why it was commented out here, please let me know if I'm mistaken here.

Did you actually test this? IntelliJ is telling me that that's not a thing in lwjgl_util 2.9.4, and I don't see it looking at Matrix4f's source either (and CI seems to agree):

@Deftu
Copy link
Author

Deftu commented May 21, 2024

Not sure as to why it was commented out here, please let me know if I'm mistaken here.

Did you actually test this? IntelliJ is telling me that that's not a thing in lwjgl_util 2.9.4, and I don't see it looking at Matrix4f's source either (and CI seems to agree):

Yes, I tested it in another project and the method existed.

@Johni0702
Copy link
Collaborator

But.. it doesn't? CI is failing and there's no hint of it even on the master branch of lwjgl2.

@Deftu
Copy link
Author

Deftu commented May 21, 2024

Yes, I can see that. I'm more confused by the fact that when I used it in the other project, not only did IntelliSense report that the method existed, but it also compiled and ran in Minecraft 1.8.9 and 1.12.2.

@Deftu Deftu closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants