Fixed some eslint issues

Expensify · Oct 2, 2024 · 0877308 · 0877308
1 parent ccadfd6
commit 0877308
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/src/libs/actions/PersistedRequests.ts b/src/libs/actions/PersistedRequests.ts
@@ -13,7 +13,7 @@ Onyx.connect({
         persistedRequests = val ?? [];
 
         if (ongoingRequest && persistedRequests.length > 0) {
-            const nextRequestToProcess = persistedRequests[0];
+            const nextRequestToProcess = persistedRequests.at(0);
 
             // We try to remove the next request from the persistedRequests if it is the same as ongoingRequest
             // so we don't process it twice.
@@ -35,6 +35,7 @@ Onyx.connect({
  */
 function clear() {
     ongoingRequest = null;
+    Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, null);
     return Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, []);
 }
 

diff --git a/tests/actions/SessionTest.ts b/tests/actions/SessionTest.ts
@@ -118,7 +118,7 @@ describe('Session', () => {
         await waitForBatchedUpdates();
 
         expect(PersistedRequests.getAll().length).toBe(1);
-        expect(PersistedRequests.getAll()[0].command).toBe(WRITE_COMMANDS.RECONNECT_APP);
+        expect(PersistedRequests.getAll().at(0)?.command).toBe(WRITE_COMMANDS.RECONNECT_APP);
 
         await Onyx.set(ONYXKEYS.NETWORK, {isOffline: false});
 
@@ -140,7 +140,7 @@ describe('Session', () => {
         await waitForBatchedUpdates();
 
         expect(PersistedRequests.getAll().length).toBe(1);
-        expect(PersistedRequests.getAll()[0].command).toBe(WRITE_COMMANDS.RECONNECT_APP);
+        expect(PersistedRequests.getAll().at(0)?.command).toBe(WRITE_COMMANDS.RECONNECT_APP);
 
         await Onyx.set(ONYXKEYS.NETWORK, {isOffline: false});
 

diff --git a/tests/unit/PersistedRequests.ts b/tests/unit/PersistedRequests.ts
@@ -57,7 +57,7 @@ describe('PersistedRequests', () => {
         PersistedRequests.processNextRequest();
         return waitForBatchedUpdates().then(() => {
             expect(PersistedRequests.getAll().length).toBe(1);
-            expect(PersistedRequests.getAll()[0]).toEqual(request2);
+            expect(PersistedRequests.getAll().at(0)).toEqual(request2);
         });
     });
 
@@ -68,7 +68,7 @@ describe('PersistedRequests', () => {
             failureData: [{key: 'reportMetadata_2', onyxMethod: 'set', value: {}}],
         };
         PersistedRequests.update(0, newRequest);
-        expect(PersistedRequests.getAll()[0]).toEqual(newRequest);
+        expect(PersistedRequests.getAll().at(0)).toEqual(newRequest);
     });
 
     it('update the ongoing request with new data', () => {

diff --git a/tests/unit/SequentialQueueTest.ts b/tests/unit/SequentialQueueTest.ts
@@ -57,7 +57,7 @@ describe('SequentialQueue', () => {
         expect(PersistedRequests.getLength()).toBe(1);
         // We know there is only one request in the queue, so we can get the first one and verify
         // that the persisted request is the second one.
-        const persistedRequest = PersistedRequests.getAll()[0];
+        const persistedRequest = PersistedRequests.getAll().at(0);
         expect(persistedRequest?.data?.accountID).toBe(56789);
     });
 
@@ -179,7 +179,7 @@ describe('SequentialQueue', () => {
         const persistedRequests = PersistedRequests.getAll();
         // We know ReconnectApp is at index 1 in the queue, so we can get it to verify
         // that was replaced by the new request.
-        expect(persistedRequests[1]?.data?.accountID).toBe(56789);
+        expect(persistedRequests.at(1)?.data?.accountID).toBe(56789);
     });
 
     // need to test a rance condition between processing the next request and then pushing a new request with conflict resolver
@@ -223,8 +223,8 @@ describe('SequentialQueue', () => {
 
         // We know ReconnectApp is at index 9 in the queue, so we can get it to verify
         // that was replaced by the new request.
-        expect(persistedRequests[9]?.command).toBe('ReconnectApp-replaced');
-        expect(persistedRequests[9]?.data?.accountID).toBe(56789);
+        expect(persistedRequests.at(9)?.command).toBe('ReconnectApp-replaced');
+        expect(persistedRequests.at(9)?.data?.accountID).toBe(56789);
     });
 
     // I need to test now when moving the request from the queue to the ongoing request the PERSISTED_REQUESTS is decreased and PERSISTED_ONGOING_REQUESTS has the new request