Rename web and desktop sourcemaps artifacts before assets upload

Expensify · Sep 6, 2024 · 0eec03c · 0eec03c
1 parent 0702a97
commit 0eec03c
Showing 1 changed file with 19 additions and 6 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -490,16 +490,21 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ github.token }}
 
+      - name: Rename web and desktop sourcemaps artifacts before assets upload in order to have unique ReleaseAsset.name
+        run: |
+          mv ./desktop-sourcemaps/merged-source-map.js.map ./desktop-sourcemaps/desktop-merged-source-map.js.map
+          mv ./web-sourcemaps/merged-source-map.js.map ./web-sourcemaps/web-merged-source-map.js.map
+
       - name: Upload artifacts to GitHub Release
         run: |
           gh release upload ${{ env.STAGING_VERSION }} \
             ./android-sourcemaps-artifact/index.android.bundle.map#android-sourcemap-${{ env.STAGING_VERSION }} \
             ./android-build-artifact/app-production-release.aab \
-            ./desktop-sourcemaps-artifact/merged-source-map.js.map#desktop-sourcemap-${{ env.STAGING_VERSION }} \
+            ./desktop-sourcemaps-artifact/desktop-merged-source-map.js.map#desktop-sourcemap-${{ env.STAGING_VERSION }} \
             ./desktop-build-artifact/NewExpensify.dmg \
             ./ios-sourcemaps-artifact/main.jsbundle.map#ios-sourcemap-${{ env.STAGING_VERSION }} \
             ./ios-build-artifact/New\ Expensify.ipa \
-            ./web-sourcemaps-artifact/merged-source-map.js.map#web-sourcemap-${{ env.STAGING_VERSION }} \
+            ./web-sourcemaps-artifact/web-merged-source-map.js.map#web-sourcemap-${{ env.STAGING_VERSION }} \
             ./web-build-tar-gz-artifact/webBuild.tar.gz \
             ./web-build-zip-artifact/webBuild.zip
         env:
@@ -528,18 +533,26 @@ jobs:
     if: ${{ github.ref == 'refs/heads/production' && fromJSON(needs.checkDeploymentSuccess.outputs.IS_AT_LEAST_ONE_PLATFORM_DEPLOYED) }}
     needs: [checkDeploymentSuccess]
     steps:
-      - uses: actions/checkout@v4
-        name: Checkout
+      - name: Checkout production branch
+        uses: actions/checkout@v4
 
       - name: Get current app version
         run: echo "PRODUCTION_VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV"
 
+      - name: Download all workflow run artifacts
+        uses: actions/download-artifact@v4
+
+      - name: Rename web and desktop sourcemaps artifacts before assets upload in order to have unique ReleaseAsset.name
+        run: |
+          mv ./desktop-sourcemaps/merged-source-map.js.map ./desktop-sourcemaps/desktop-merged-source-map.js.map
+          mv ./web-sourcemaps/merged-source-map.js.map ./web-sourcemaps/web-merged-source-map.js.map
+
       - name: Upload artifacts to GitHub Release
         run: |
           gh release upload ${{ env.STAGING_VERSION }} \
-            ./desktop-sourcemaps-artifact/merged-source-map.js.map#desktop-sourcemap-${{ env.STAGING_VERSION }} \
+            ./desktop-sourcemaps-artifact/desktop-merged-source-map.js.map#desktop-sourcemap-${{ env.STAGING_VERSION }} \
             ./desktop-build-artifact/NewExpensify.dmg \
-            ./web-sourcemaps-artifact/merged-source-map.js.map#web-sourcemap-${{ env.STAGING_VERSION }} \
+            ./web-sourcemaps-artifact/web-merged-source-map.js.map#web-sourcemap-${{ env.STAGING_VERSION }} \
             ./web-build-tar-gz-artifact/webBuild.tar.gz \
             ./web-build-zip-artifact/webBuild.zip
         env: