Skip to content

Commit

Permalink
Merge pull request #41392 from tienifr/fix/regression-38497
Browse files Browse the repository at this point in the history
Save button does not move above the keyboard when keyboard is up
  • Loading branch information
luacmartins authored May 2, 2024
2 parents daf3045 + e500fdd commit 5bb3329
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/components/TextPicker/TextSelectorModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,17 @@ import ScreenWrapper from '@components/ScreenWrapper';
import ScrollView from '@components/ScrollView';
import TextInput from '@components/TextInput';
import useLocalize from '@hooks/useLocalize';
import useStyledSafeAreaInsets from '@hooks/useStyledSafeAreaInsets';
import useThemeStyles from '@hooks/useThemeStyles';
import CONST from '@src/CONST';
import type {TextSelectorModalProps} from './types';
import usePaddingStyle from './usePaddingStyle';

function TextSelectorModal({value, description = '', onValueSelected, isVisible, onClose, ...rest}: TextSelectorModalProps) {
const {translate} = useLocalize();
const styles = useThemeStyles();

const [currentValue, setValue] = useState(value);

const {paddingTop, paddingBottom} = useStyledSafeAreaInsets();
const paddingStyle = usePaddingStyle();

return (
<Modal
Expand All @@ -35,7 +34,7 @@ function TextSelectorModal({value, description = '', onValueSelected, isVisible,
includeSafeAreaPaddingBottom={false}
testID={TextSelectorModal.displayName}
shouldEnableMaxHeight
style={{paddingTop, paddingBottom}}
style={paddingStyle}
>
<HeaderWithBackButton
title={description}
Expand Down
9 changes: 9 additions & 0 deletions src/components/TextPicker/usePaddingStyle/index.android.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import useKeyboardState from '@hooks/useKeyboardState';
import useStyledSafeAreaInsets from '@hooks/useStyledSafeAreaInsets';

export default function usePaddingStyle() {
const {keyboardHeight} = useKeyboardState();
const {paddingTop} = useStyledSafeAreaInsets();

return {paddingTop, paddingBottom: keyboardHeight};
}
6 changes: 6 additions & 0 deletions src/components/TextPicker/usePaddingStyle/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import useStyledSafeAreaInsets from '@hooks/useStyledSafeAreaInsets';

export default function usePaddingStyle() {
const {paddingTop, paddingBottom} = useStyledSafeAreaInsets();
return {paddingTop, paddingBottom};
}

0 comments on commit 5bb3329

Please sign in to comment.