chore: move around the timing trigger for the CHAT_FINDER_RENDER event

Expensify · Jul 29, 2024 · 6423ba3 · 6423ba3
1 parent dbc4ad4
commit 6423ba3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx
@@ -11,8 +11,10 @@ import useLocalize from '@hooks/useLocalize';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import Navigation from '@libs/Navigation/Navigation';
+import Performance from '@libs/Performance';
 import SignInButton from '@pages/home/sidebar/SignInButton';
 import * as Session from '@userActions/Session';
+import Timing from '@userActions/Timing';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
@@ -62,7 +64,11 @@ function TopBar({breadcrumbLabel, activeWorkspaceID, shouldDisplaySearch = true}
                         <PressableWithoutFeedback
                             accessibilityLabel={translate('sidebarScreen.buttonFind')}
                             style={[styles.flexRow, styles.mr2, styles.touchableButtonImage]}
-                            onPress={Session.checkIfActionIsAllowed(() => Navigation.navigate(ROUTES.CHAT_FINDER))}
+                            onPress={Session.checkIfActionIsAllowed(() => {
+                                Timing.start(CONST.TIMING.CHAT_FINDER_RENDER);
+                                Performance.markStart(CONST.TIMING.CHAT_FINDER_RENDER);
+                                Navigation.navigate(ROUTES.CHAT_FINDER);
+                            })}
                         >
                             <Icon
                                 src={Expensicons.MagnifyingGlass}

diff --git a/src/pages/ChatFinderPage/index.tsx b/src/pages/ChatFinderPage/index.tsx
@@ -71,11 +71,6 @@ function ChatFinderPage({betas, isSearchingForReports, navigation}: ChatFinderPa
     );
     useCancelSearchOnModalClose();
 
-    useEffect(() => {
-        Timing.start(CONST.TIMING.CHAT_FINDER_RENDER);
-        Performance.markStart(CONST.TIMING.CHAT_FINDER_RENDER);
-    }, []);
-
     useEffect(() => {
         Report.searchInServer(debouncedSearchValueInServer.trim());
     }, [debouncedSearchValueInServer]);