Skip to content

Commit

Permalink
fixed eslint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
gedu committed Oct 7, 2024
1 parent ee7f37f commit 6a9cc01
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/libs/actions/App.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {OnyxCollection, OnyxEntry, OnyxUpdate} from 'react-native-onyx';
import Onyx from 'react-native-onyx';
import type {ValueOf} from 'type-fest';
import {importEmojiLocale} from '@assets/emojis';
import {resolveDuplicationConflictAction} from '@libs/actions/RequestConflictUtils';
import resolveDuplicationConflictAction from '@libs/actions/RequestConflictUtils';

Check warning on line 9 in src/libs/actions/App.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

Unexpected subpath import via alias '@libs/actions/RequestConflictUtils'. Use './RequestConflictUtils' instead
import * as API from '@libs/API';
import type {GetMissingOnyxMessagesParams, HandleRestrictedEventParams, OpenAppParams, OpenOldDotLinkParams, ReconnectAppParams, UpdatePreferredLocaleParams} from '@libs/API/parameters';
import {SIDE_EFFECT_REQUEST_COMMANDS, WRITE_COMMANDS} from '@libs/API/types';
Expand Down
3 changes: 1 addition & 2 deletions src/libs/actions/RequestConflictUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import type OnyxRequest from '@src/types/onyx/Request';
import type {ConflictActionData} from '@src/types/onyx/Request';

function resolveDuplicationConflictAction(persistedRequests: OnyxRequest[], commandToFind: WriteCommand): ConflictActionData {
console.log('resolveDuplicationConflictAction -> ', commandToFind);
const index = persistedRequests.findIndex((request) => request.command === commandToFind);
if (index === -1) {
return {
Expand All @@ -21,4 +20,4 @@ function resolveDuplicationConflictAction(persistedRequests: OnyxRequest[], comm
};
}

export {resolveDuplicationConflictAction};
export default resolveDuplicationConflictAction;
7 changes: 2 additions & 5 deletions tests/unit/RequestConflictUtilsTest.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import {resolveDuplicationConflictAction} from '@libs/actions/RequestConflictUtils';
import resolveDuplicationConflictAction from '@libs/actions/RequestConflictUtils';
import type {WriteCommand} from '@libs/API/types';

describe('RequestConflictUtils', () => {
it.each([
['OpenApp', 0],
['ReconnectApp', 0],
])('resolveDuplicationConflictAction when %s do not exist in the queue should push %i', (command, index) => {
it.each([['OpenApp'], ['ReconnectApp']])('resolveDuplicationConflictAction when %s do not exist in the queue should push %i', (command) => {
const persistedRequests = [{command: 'OpenReport'}, {command: 'AddComment'}, {command: 'CloseAccount'}];
const commandToFind = command as WriteCommand;
const result = resolveDuplicationConflictAction(persistedRequests, commandToFind);
Expand Down

0 comments on commit 6a9cc01

Please sign in to comment.