Merge pull request #31549 from OlimpiaZurek/fix/31145-reassure-test-f…

…lakines add global config for timeouts
Expensify · Nov 22, 2023 · 704f3f7 · 704f3f7
2 parents 34d165e + 060a46c
commit 704f3f7
Show file tree

Hide file tree

Showing 10 changed files with 43 additions and 48 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -24,7 +24,7 @@ module.exports = {
     },
     testEnvironment: 'jsdom',
     setupFiles: ['<rootDir>/jest/setup.js', './node_modules/@react-native-google-signin/google-signin/jest/build/setup.js'],
-    setupFilesAfterEnv: ['@testing-library/jest-native/extend-expect', '<rootDir>/jest/setupAfterEnv.js'],
+    setupFilesAfterEnv: ['@testing-library/jest-native/extend-expect', '<rootDir>/jest/setupAfterEnv.js', '<rootDir>/tests/perf-test/setupAfterEnv.js'],
     cacheDirectory: '<rootDir>/.jest-cache',
     moduleNameMapper: {
         '\\.(lottie)$': '<rootDir>/__mocks__/fileMock.js',

diff --git a/src/CONST.ts b/src/CONST.ts
@@ -2901,6 +2901,13 @@ const CONST = {
     },
 
     BACK_BUTTON_NATIVE_ID: 'backButton',
+
+    /**
+     * Performance test setup - run the same test multiple times to get a more accurate result
+     */
+    PERFORMANCE_TESTS: {
+        RUNS: 20,
+    },
 } as const;
 
 export default CONST;
diff --git a/tests/perf-test/GooglePlacesUtils.perf-test.js b/tests/perf-test/GooglePlacesUtils.perf-test.js
@@ -1,8 +1,6 @@
 import {measureFunction} from 'reassure';
 import * as GooglePlacesUtils from '../../src/libs/GooglePlacesUtils';
 
-jest.setTimeout(60000);
-
 const addressComponents = [
     {
         long_name: 'Bushwick',

diff --git a/tests/perf-test/ReportActionCompose.perf-test.js b/tests/perf-test/ReportActionCompose.perf-test.js
@@ -7,14 +7,13 @@ import {LocaleContextProvider} from '../../src/components/LocaleContextProvider'
 import OnyxProvider from '../../src/components/OnyxProvider';
 import {KeyboardStateProvider} from '../../src/components/withKeyboardState';
 import {WindowDimensionsProvider} from '../../src/components/withWindowDimensions';
+import CONST from '../../src/CONST';
 import * as Localize from '../../src/libs/Localize';
 import ONYXKEYS from '../../src/ONYXKEYS';
 import ReportActionCompose from '../../src/pages/home/report/ReportActionCompose/ReportActionCompose';
 import * as LHNTestUtils from '../utils/LHNTestUtils';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 
-jest.setTimeout(60000);
-
 // mock PortalStateContext
 jest.mock('@gorhom/portal');
 
@@ -69,6 +68,8 @@ beforeEach(() => {
     Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false});
 });
 
+const runs = CONST.PERFORMANCE_TESTS.RUNS;
+
 function ReportActionComposeWrapper() {
     return (
         <ComposeProviders components={[OnyxProvider, LocaleContextProvider, KeyboardStateProvider, WindowDimensionsProvider]}>
@@ -87,8 +88,6 @@ test('should render Composer with text input interactions', async () => {
     const scenario = async () => {
         // Query for the composer
         const composer = await screen.findByTestId('composer');
-
-        expect(composer).toBeDefined();
         fireEvent.changeText(composer, '@test');
 
         // Query for the suggestions
@@ -101,7 +100,7 @@ test('should render Composer with text input interactions', async () => {
         fireEvent.press(composer);
     };
 
-    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario}));
+    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario, runs}));
 });
 
 test('should press add attachemnt button', async () => {
@@ -110,11 +109,10 @@ test('should press add attachemnt button', async () => {
         const hintAttachmentButtonText = Localize.translateLocal('reportActionCompose.addAction');
         const attachmentButton = await screen.findByLabelText(hintAttachmentButtonText);
 
-        expect(attachmentButton).toBeDefined();
         fireEvent.press(attachmentButton, mockEvent);
     };
 
-    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario}));
+    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario, runs}));
 });
 
 test('should press add emoji button', async () => {
@@ -123,11 +121,10 @@ test('should press add emoji button', async () => {
         const hintEmojiButtonText = Localize.translateLocal('reportActionCompose.emoji');
         const emojiButton = await screen.findByLabelText(hintEmojiButtonText);
 
-        expect(emojiButton).toBeDefined();
         fireEvent.press(emojiButton);
     };
 
-    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario}));
+    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario, runs}));
 });
 
 test('should press send message button', async () => {
@@ -136,11 +133,10 @@ test('should press send message button', async () => {
         const hintSendButtonText = Localize.translateLocal('common.send');
         const sendButton = await screen.findByLabelText(hintSendButtonText);
 
-        expect(sendButton).toBeDefined();
         fireEvent.press(sendButton);
     };
 
-    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario}));
+    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario, runs}));
 });
 
 test('render composer with attachement modal interactions', async () => {
@@ -160,5 +156,5 @@ test('render composer with attachement modal interactions', async () => {
         fireEvent.press(assignTaskButton, mockEvent);
     };
 
-    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario}));
+    return waitForBatchedUpdates().then(() => measurePerformance(<ReportActionComposeWrapper />, {scenario, runs}));
 });
diff --git a/tests/perf-test/ReportActionsList.perf-test.js b/tests/perf-test/ReportActionsList.perf-test.js
@@ -5,6 +5,7 @@ import ComposeProviders from '../../src/components/ComposeProviders';
 import {LocaleContextProvider} from '../../src/components/LocaleContextProvider';
 import OnyxProvider from '../../src/components/OnyxProvider';
 import {WindowDimensionsProvider} from '../../src/components/withWindowDimensions';
+import CONST from '../../src/CONST';
 import * as Localize from '../../src/libs/Localize';
 import ONYXKEYS from '../../src/ONYXKEYS';
 import ReportActionsList from '../../src/pages/home/report/ReportActionsList';
@@ -17,8 +18,6 @@ import * as ReportTestUtils from '../utils/ReportTestUtils';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatchedUpdates';
 
-jest.setTimeout(60000);
-
 const mockedNavigate = jest.fn();
 
 jest.mock('../../src/components/withNavigationFocus', () => (Component) => {
@@ -98,6 +97,8 @@ function ReportActionsListWrapper() {
     );
 }
 
+const runs = CONST.PERFORMANCE_TESTS.RUNS;
+
 test('should render ReportActionsList with 500 reportActions stored', () => {
     const scenario = async () => {
         await screen.findByTestId('report-actions-list');
@@ -112,7 +113,7 @@ test('should render ReportActionsList with 500 reportActions stored', () => {
                 [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
             }),
         )
-        .then(() => measurePerformance(<ReportActionsListWrapper />, {scenario}));
+        .then(() => measurePerformance(<ReportActionsListWrapper />, {scenario, runs}));
 });
 
 test('should scroll and click some of the reports', () => {
@@ -136,8 +137,6 @@ test('should scroll and click some of the reports', () => {
 
     const scenario = async () => {
         const reportActionsList = await screen.findByTestId('report-actions-list');
-        expect(reportActionsList).toBeDefined();
-
         fireEvent.scroll(reportActionsList, eventData);
 
         const hintText = Localize.translateLocal('accessibilityHints.chatMessage');
@@ -152,5 +151,5 @@ test('should scroll and click some of the reports', () => {
                 [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
             }),
         )
-        .then(() => measurePerformance(<ReportActionsListWrapper />, {scenario}));
+        .then(() => measurePerformance(<ReportActionsListWrapper />, {scenario, runs}));
 });
diff --git a/tests/perf-test/ReportActionsUtils.perf-test.js b/tests/perf-test/ReportActionsUtils.perf-test.js
@@ -7,8 +7,6 @@ import ONYXKEYS from '../../src/ONYXKEYS';
 import * as LHNTestUtils from '../utils/LHNTestUtils';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 
-jest.setTimeout(60000);
-
 beforeAll(() =>
     Onyx.init({
         keys: ONYXKEYS,

diff --git a/tests/perf-test/ReportScreen.perf-test.js b/tests/perf-test/ReportScreen.perf-test.js
@@ -21,8 +21,6 @@ import * as TestHelper from '../utils/TestHelper';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatchedUpdates';
 
-jest.setTimeout(60000);
-
 jest.mock('react-native-reanimated', () => ({
     ...jest.requireActual('react-native-reanimated/mock'),
     useSharedValue: jest.fn,
@@ -125,14 +123,15 @@ function ReportScreenWrapper(args) {
     );
 }
 
+const runs = CONST.PERFORMANCE_TESTS.RUNS;
+
 test.skip('should render ReportScreen with composer interactions', () => {
     const scenario = async () => {
         // Query for the report list
         await screen.findByTestId('report-actions-list');
 
         // Query for the composer
         const composer = await screen.findByTestId('composer');
-        expect(composer).toBeDefined();
 
         // Type in the composer
         fireEvent.changeText(composer, 'Test message');
@@ -141,16 +140,14 @@ test.skip('should render ReportScreen with composer interactions', () => {
 
         // Query for the send button
         const sendButton = await screen.findByLabelText(hintSendButtonText);
-        expect(sendButton).toBeDefined();
 
         // Click on the send button
         fireEvent.press(sendButton);
 
         const hintHeaderText = Localize.translateLocal('common.back');
 
         // Query for the header
-        const header = await screen.findByLabelText(hintHeaderText);
-        expect(header).toBeDefined();
+        await screen.findByLabelText(hintHeaderText);
     };
 
     const policy = {
@@ -176,7 +173,7 @@ test.skip('should render ReportScreen with composer interactions', () => {
                 },
             }),
         )
-        .then(() => measurePerformance(<ReportScreenWrapper route={mockRoute} />, {scenario}));
+        .then(() => measurePerformance(<ReportScreenWrapper route={mockRoute} />, {scenario, runs}));
 });
 
 test.skip('should press of the report item', () => {
@@ -192,8 +189,6 @@ test.skip('should press of the report item', () => {
         // Query for report preview buttons
         const reportPreviewButtons = await screen.findAllByLabelText(hintReportPreviewText);
 
-        expect(reportPreviewButtons.length).toBeDefined();
-
         // click on the report preview button
         fireEvent.press(reportPreviewButtons[0]);
     };
@@ -221,5 +216,5 @@ test.skip('should press of the report item', () => {
                 },
             }),
         )
-        .then(() => measurePerformance(<ReportScreenWrapper route={mockRoute} />, {scenario}));
+        .then(() => measurePerformance(<ReportScreenWrapper route={mockRoute} />, {scenario, runs}));
 });
diff --git a/tests/perf-test/SelectionList.perf-test.js b/tests/perf-test/SelectionList.perf-test.js
@@ -3,10 +3,9 @@ import React, {useState} from 'react';
 import {measurePerformance} from 'reassure';
 import _ from 'underscore';
 import SelectionList from '../../src/components/SelectionList';
+import CONST from '../../src/CONST';
 import variables from '../../src/styles/variables';
 
-jest.setTimeout(60000);
-
 jest.mock('../../src/components/Icon/Expensicons');
 
 jest.mock('../../src/hooks/useLocalize', () =>
@@ -94,6 +93,8 @@ function SelectionListWrapper(args) {
     );
 }
 
+const runs = CONST.PERFORMANCE_TESTS.RUNS;
+
 test('should render 1 section and a thousand items', () => {
     measurePerformance(<SelectionListWrapper />);
 });
@@ -103,7 +104,7 @@ test('should press a list item', () => {
         fireEvent.press(screen.getByText('Item 5'));
     };
 
-    measurePerformance(<SelectionListWrapper />, {scenario});
+    measurePerformance(<SelectionListWrapper />, {scenario, runs});
 });
 
 test('should render multiple selection and select 3 items', () => {
@@ -113,7 +114,7 @@ test('should render multiple selection and select 3 items', () => {
         fireEvent.press(screen.getByText('Item 3'));
     };
 
-    measurePerformance(<SelectionListWrapper canSelectMultiple />, {scenario});
+    measurePerformance(<SelectionListWrapper canSelectMultiple />, {scenario, runs});
 });
 
 test('should scroll and select a few items', () => {
@@ -142,5 +143,5 @@ test('should scroll and select a few items', () => {
         fireEvent.press(screen.getByText('Item 15'));
     };
 
-    measurePerformance(<SelectionListWrapper canSelectMultiple />, {scenario});
+    measurePerformance(<SelectionListWrapper canSelectMultiple />, {scenario, runs});
 });
diff --git a/tests/perf-test/SidebarLinks.perf-test.js b/tests/perf-test/SidebarLinks.perf-test.js
@@ -9,13 +9,6 @@ import * as LHNTestUtils from '../utils/LHNTestUtils';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatchedUpdates';
 
-/**
- * Performance tests with Reassure can require big timeouts as all runs
- * for a test have to be executed within this limit. (default runs=10)
- * This also includes manual garbage collection between them.
- */
-jest.setTimeout(60000);
-
 jest.mock('../../src/libs/Permissions');
 jest.mock('../../src/libs/Navigation/Navigation');
 jest.mock('../../src/components/Icon/Expensicons');
@@ -56,6 +49,8 @@ const getMockedReportsMap = (length = 100) => {
 
 const mockedResponseMap = getMockedReportsMap(500);
 
+const runs = CONST.PERFORMANCE_TESTS.RUNS;
+
 test('should render Sidebar with 500 reports stored', () => {
     const scenario = async () => {
         // Query for the sidebar
@@ -78,7 +73,7 @@ test('should render Sidebar with 500 reports stored', () => {
                 ...mockedResponseMap,
             }),
         )
-        .then(() => measurePerformance(<LHNTestUtils.MockedSidebarLinks />, {scenario}));
+        .then(() => measurePerformance(<LHNTestUtils.MockedSidebarLinks />, {scenario, runs}));
 });
 
 test('should scroll and click some of the items', () => {
@@ -102,7 +97,6 @@ test('should scroll and click some of the items', () => {
         };
 
         const lhnOptionsList = await screen.findByTestId('lhn-options-list');
-        expect(lhnOptionsList).toBeDefined();
 
         fireEvent.scroll(lhnOptionsList, eventData);
 
@@ -123,5 +117,5 @@ test('should scroll and click some of the items', () => {
                 ...mockedResponseMap,
             }),
         )
-        .then(() => measurePerformance(<LHNTestUtils.MockedSidebarLinks />, {scenario}));
+        .then(() => measurePerformance(<LHNTestUtils.MockedSidebarLinks />, {scenario, runs}));
 });
diff --git a/tests/perf-test/setupAfterEnv.js b/tests/perf-test/setupAfterEnv.js
@@ -0,0 +1,7 @@
+/**
+ * Performance tests with Reassure can require big timeouts as all runs
+ * for a test have to be executed within this limit. (default runs=10)
+ * This also includes manual garbage collection between them.
+ */
+
+jest.setTimeout(240000); // 4 minutes