Merge pull request #10856 from Expensify/Rory-FixGetPRDetails

[No QA] Fetch full PR object to fix CPs
Expensify · Sep 7, 2022 · 7747acd · 7747acd
2 parents 909c5da + 4126578
commit 7747acd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/.github/actions/javascript/getPullRequestDetails/getPullRequestDetails.js b/.github/actions/javascript/getPullRequestDetails/getPullRequestDetails.js
@@ -87,9 +87,13 @@ if (pullRequestNumber) {
         ...DEFAULT_PAYLOAD,
         state: 'all',
     })
+        .then(({data}) => _.find(data, PR => PR.user.login === user && titleRegex.test(PR.title)).number)
+        .then(matchingPRNum => GithubUtils.octokit.pulls.get({
+            ...DEFAULT_PAYLOAD,
+            pull_number: matchingPRNum,
+        }))
         .then(({data}) => {
-            const matchingPR = _.find(data, PR => PR.user.login === user && titleRegex.test(PR.title));
-            outputMergeCommitHash(matchingPR);
-            outputMergeActor(matchingPR);
+            outputMergeCommitHash(data);
+            outputMergeActor(data);
         });
 }
diff --git a/.github/actions/javascript/getPullRequestDetails/index.js b/.github/actions/javascript/getPullRequestDetails/index.js
@@ -97,10 +97,14 @@ if (pullRequestNumber) {
         ...DEFAULT_PAYLOAD,
         state: 'all',
     })
+        .then(({data}) => _.find(data, PR => PR.user.login === user && titleRegex.test(PR.title)).number)
+        .then(matchingPRNum => GithubUtils.octokit.pulls.get({
+            ...DEFAULT_PAYLOAD,
+            pull_number: matchingPRNum,
+        }))
         .then(({data}) => {
-            const matchingPR = _.find(data, PR => PR.user.login === user && titleRegex.test(PR.title));
-            outputMergeCommitHash(matchingPR);
-            outputMergeActor(matchingPR);
+            outputMergeCommitHash(data);
+            outputMergeActor(data);
         });
 }