fix: rename functions

Signed-off-by: dominictb <tb-dominic@outlook.com>
Expensify · Jun 14, 2024 · 7c9396e · 7c9396e
1 parent c62c3bc
commit 7c9396e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx b/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx
@@ -85,10 +85,6 @@ function IOURequestStepTaxRatePage({
 
         if (isEditing) {
             const newTaxCode = taxes.code;
-            if (newTaxCode === TransactionUtils.getTaxCode(currentTransaction)) {
-                navigateBack();
-                return;
-            }
             IOU.updateMoneyRequestTaxRate({
                 transactionID: currentTransaction?.transactionID ?? '-1',
                 optimisticReportActionID: report?.reportID ?? '-1',
@@ -113,10 +109,6 @@ function IOURequestStepTaxRatePage({
         navigateBack();
     };
 
-    const dismiss = () => {
-        navigateBack();
-    };
-
     return (
         <StepScreenWrapper
             headerTitle={translate('iou.taxRate')}
@@ -131,7 +123,7 @@ function IOURequestStepTaxRatePage({
                 onSubmit={updateTaxRates}
                 action={action}
                 iouType={iouType}
-                onDismiss={dismiss}
+                onDismiss={navigateBack}
             />
         </StepScreenWrapper>
     );

diff --git a/src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx b/src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx
@@ -38,7 +38,7 @@ function WorkspaceTaxesSettingsForeignCurrency({
         Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
     };
 
-    const onDismiss = () => {
+    const dismiss = () => {
         Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
     };
 
@@ -64,7 +64,7 @@ function WorkspaceTaxesSettingsForeignCurrency({
                                 policyID={policyID}
                                 insets={insets}
                                 onSubmit={submit}
-                                onDismiss={onDismiss}
+                                onDismiss={dismiss}
                             />
                         </View>
                     </>