Fix shellcheck lint issues

Expensify · Oct 3, 2024 · daa0ad6 · daa0ad6
1 parent e567ee3
commit daa0ad6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/scripts/check-for-old-dot-changes.sh b/scripts/check-for-old-dot-changes.sh
@@ -22,7 +22,7 @@ if [[ "$IS_HYBRID_APP_REPO" == "true" ]]; then
 
     # Count the number of commits behind
     UPSTREAM=${1:-'@{u}'}
-    COMMITS_BEHIND=$(git rev-list --count HEAD..$UPSTREAM)
+    COMMITS_BEHIND=$(git rev-list --count HEAD.."$UPSTREAM")
 
     if [[ $COMMITS_BEHIND -eq 0 ]]; then
         echo -e "\n${GREEN}OldDot repository is up to date!${NC}"

diff --git a/scripts/run-build.sh b/scripts/run-build.sh
@@ -9,7 +9,6 @@ SCHEME="New Expensify Dev"
 APP_ID="com.expensify.chat.dev"
 
 GREEN='\033[1;32m'
-YELLOW='\033[1;33m'
 RED='\033[1;31m'
 NC='\033[0m'
 
@@ -60,19 +59,18 @@ fi
 # Check if the argument is one of the desired values
 case "$BUILD" in
     --ios)
-        npx react-native run-ios --list-devices --mode $IOS_MODE --scheme $SCHEME
+        npx react-native run-ios --list-devices --mode $IOS_MODE --scheme "$SCHEME"
         ;;
     --ipad)
-        npx react-native run-ios --simulator "iPad Pro (12.9-inch) (6th generation)" --mode $IOS_MODE --scheme $SCHEME
+        npx react-native run-ios --simulator "iPad Pro (12.9-inch) (6th generation)" --mode $IOS_MODE --scheme "$SCHEME"
         ;;
     --ipad-sm)
-        npx react-native run-ios --simulator "iPad Pro (11-inch) (4th generation)" --mode $IOS_MODE --scheme $SCHEME
+        npx react-native run-ios --simulator "iPad Pro (11-inch) (4th generation)" --mode $IOS_MODE --scheme "$SCHEME"
         ;;
     --android)
         npx react-native run-android --list-devices --mode $ANDROID_MODE --appId $APP_ID --active-arch-only
         ;;
     *)
         print_error_and_exit
-        exit 1
         ;;
 esac