Fix type error and review sugestions

Expensify · Jul 31, 2024 · ee320a8 · ee320a8
1 parent 53c0802
commit ee320a8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/libs/SearchUtils.ts b/src/libs/SearchUtils.ts
@@ -375,11 +375,11 @@ function buildDateFilterQuery(filterValues: Partial<SearchAdvancedFiltersForm>)
     return dateFilter;
 }
 
-function sanitizeCategoryName(category: string) {
-    if (category.includes(' ')) {
-        return `"${category}"`;
+function sanitizeString(str: string) {
+    if (str.includes(' ')) {
+        return `"${str}"`;
     }
-    return category;
+    return str;
 }
 
 /**
@@ -398,8 +398,8 @@ function buildQueryStringFromFilters(filterValues: Partial<SearchAdvancedFilters
             }
 
             if (filterKey === INPUT_IDS.CATEGORY && filterValues[filterKey]) {
-                const categories = filterValues[filterKey];
-                return `${CONST.SEARCH.SYNTAX_FILTER_KEYS.CATEGORY}:${categories.map((category) => sanitizeCategoryName(category)).join(',')}`;
+                const categories = filterValues[filterKey] ?? [];
+                return `${CONST.SEARCH.SYNTAX_FILTER_KEYS.CATEGORY}:${categories.map(sanitizeString).join(',')}`;
             }
 
             return undefined;

diff --git a/src/pages/Search/AdvancedSearchFilters.tsx b/src/pages/Search/AdvancedSearchFilters.tsx
@@ -37,8 +37,8 @@ function getFilterDisplayTitle(filters: Partial<SearchAdvancedFiltersForm>, fiel
     }
 
     if (fieldName === CONST.SEARCH.SYNTAX_FILTER_KEYS.CATEGORY && filters[fieldName]) {
-        const categories = filters[fieldName];
-        return categories.map((category) => Str.recapitalize(category)).join(', ');
+        const categories = filters[fieldName] ?? [];
+        return categories.join(', ');
     }
 
     // Todo Once all Advanced filters are implemented this line can be cleaned up. See: https://github.com/Expensify/App/issues/45026

diff --git a/src/pages/Search/SearchFiltersCategoryPage.tsx b/src/pages/Search/SearchFiltersCategoryPage.tsx
@@ -30,21 +30,21 @@ function SearchFiltersCategoryPage() {
     const [newCategories, setNewCategories] = useState<string[]>(currentCategories ?? []);
     const policyID = searchAdvancedFiltersForm?.policyID ?? '-1';
 
-    const [allPolicyIdCategories] = useOnyx(ONYXKEYS.COLLECTION.POLICY_CATEGORIES);
-    const singlePolicyCategories = allPolicyIdCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`];
+    const [allPolicyIDCategories] = useOnyx(ONYXKEYS.COLLECTION.POLICY_CATEGORIES);
+    const singlePolicyCategories = allPolicyIDCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`];
 
     const categoryNames = useMemo(() => {
         let categories: string[] = [];
         if (!singlePolicyCategories) {
-            categories = Object.values(allPolicyIdCategories ?? {})
+            categories = Object.values(allPolicyIDCategories ?? {})
                 .map((policyCategories) => Object.values(policyCategories ?? {}).map((category) => category.name))
                 .flat();
         } else {
             categories = Object.values(singlePolicyCategories ?? {}).map((value) => value.name);
         }
 
         return [...new Set(categories)];
-    }, [allPolicyIdCategories, singlePolicyCategories]);
+    }, [allPolicyIDCategories, singlePolicyCategories]);
 
     const sections = useMemo(() => {
         const newSections: CategorySection[] = [];