Skip to content

Commit

Permalink
Merge pull request #24116 from alphaboss1104/23609-Bug-Fix
Browse files Browse the repository at this point in the history
fix no scroll bar in several pages
  • Loading branch information
marcochavezf authored Aug 3, 2023
2 parents 3396329 + 1b8b064 commit f9d760f
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/OptionsList/BaseOptionsList.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class BaseOptionsList extends Component {
onScrollBeginDrag={this.props.onScrollBeginDrag}
onScroll={this.props.onScroll}
contentContainerStyle={this.props.contentContainerStyles}
showsVerticalScrollIndicator={false}
showsVerticalScrollIndicator={this.props.showScrollIndicator}
sections={this.props.sections}
keyExtractor={this.extractKey}
stickySectionHeadersEnabled={false}
Expand Down
4 changes: 4 additions & 0 deletions src/components/OptionsList/optionsListPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ const propTypes = {

/** Whether to disable the inner padding in rows */
shouldDisableRowInnerPadding: PropTypes.bool,

/** Whether to show the scroll bar */
showScrollIndicator: PropTypes.bool,
};

const defaultProps = {
Expand All @@ -97,6 +100,7 @@ const defaultProps = {
onLayout: undefined,
shouldHaveOptionSeparator: false,
shouldDisableRowInnerPadding: false,
showScrollIndicator: false,
};

export {propTypes, defaultProps};
1 change: 1 addition & 0 deletions src/components/OptionsSelector/BaseOptionsSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ class BaseOptionsSelector extends Component {
contentContainerStyles={[safeAreaPaddingBottomStyle, ...this.props.contentContainerStyles]}
listContainerStyles={this.props.listContainerStyles}
isLoading={!this.props.shouldShowOptions}
showScrollIndicator={this.props.showScrollIndicator}
/>
);
return (
Expand Down
1 change: 1 addition & 0 deletions src/pages/ReportParticipantsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ function ReportParticipantsPage(props) {
}}
hideSectionHeaders
showTitleTooltip
showScrollIndicator
disableFocusOptions
boldStyle
optionHoveredStyle={styles.hoveredComponentBG}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/WorkspaceInvitePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ function WorkspaceInvitePage(props) {
onChangeText={setSearchTerm}
onConfirmSelection={inviteUser}
headerMessage={headerMessage}
showScrollIndicator
hideSectionHeaders
boldStyle
shouldDelayFocus
Expand Down

0 comments on commit f9d760f

Please sign in to comment.