-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$2000] Web/mweb - Chat - LHN does not display after signing out/signing in #11011
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @johnmlee101 ( |
I can't reproduce this on |
Asked here for someone else to confirm, as I wasn't able to reproduce |
I was able to reproduce but not consistently |
Updating the title to be more accurate. |
This happens while OpenApp is processing, and the result of OpenApp looks fine, so its the render that follows thats failing? |
I can consistently reproduce on web with the account applausetester+0901abb@applause.expensifail.com. Should we just revert #10784 for now? |
@francoisl can we confirm that reverting #10784 fixes the issue? |
No because I don't think anyone was able to reproduce the issue in dev in the first place, but the idea is:
|
We'd have to revert the CP as well if we go this route, right? |
Yes we'd either revert the CP first, or there would be a conflict if we directly revert #10784. We can do both reverts in one PR though, it's not really a problem. |
Okay I'd say to prevent blocking another deploy let's do that. Order of operations is
Correct? |
Yes and we can make steps 1 and 2 in one PR - give me a second to double check. |
We can reproduce this in production too - it might be related to a recent Web-E change though, let's keep this open as a high-priority issue. |
lol why does Melvin keep assigning internal engineers? Am I the CME for this issue? |
Yeah, @luacmartins , you're the CME, John and Francois aren't on the CME team. |
Created job in Upwork: Internal posting: https://www.upwork.com/ab/applicants/1577530367682449408/job-details |
Waiting for proposals |
@francoisl, @johnmlee101, @eVoloshchak, @luacmartins, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Gonna move this to a weekly while we wait for proposals. |
Doubling price to $500 |
doubled price - still waiting on proposals |
Still looking for proposals |
Price doubled $2000 - still waiting on proposals |
I'm unable to reproduce this. @kbecciv could you please ask the team to try to reproduce on the latest build? |
Issue is not reproduced in build v1.2.23-9 Recording.1611.mp4 |
Thanks @kbecciv! Ok, I'm gonna close this since we can't reproduce the issue. My guess is that the performance improvements we made to the LHN fixed this somehow. Please reopen if this happens again. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #11006
Action Performed:
Expected Result:
Chat list is loading without refreshing the page
Actual Result:
Chat list displays after refreshing
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.0.4
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/Feya86Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
11006.mWeb.2.mp4
Recording.1217.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: