Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] Web/mweb - Chat - LHN does not display after signing out/signing in #11011

Closed
kbecciv opened this issue Sep 15, 2022 · 41 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 15, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #11006

Action Performed:

  1. Go to staging.new.expensify.com
  2. Login with user applausetester+0901abb@applause.expensifail.com, using the password Feya86Katya

Expected Result:

Chat list is loading without refreshing the page

Actual Result:

Chat list displays after refreshing

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web
  • Desktop

Version Number: 1.2.0.4

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/Feya86Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

11006.mWeb.2.mp4
Recording.1217.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 15, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

I can't reproduce this on v1.2.0-4, with my own account, or with the tester credentials provided. Tested on web (Chrome) and mWeb (Android).

@kbecciv
Copy link
Author

kbecciv commented Sep 15, 2022

Adding Desktop as well for environment list
Screen Shot 2022-09-15 at 10 28 02 AM

@Julesssss
Copy link
Contributor

Asked here for someone else to confirm, as I wasn't able to reproduce

@luacmartins
Copy link
Contributor

I was able to reproduce but not consistently

@mountiny
Copy link
Contributor

Updating the title to be more accurate.

@mountiny mountiny changed the title Web/mweb - Chat - Chat list displays after refreshing the page Web/mweb - Chat - Chat list does not display after signing it Sep 15, 2022
@mountiny mountiny changed the title Web/mweb - Chat - Chat list does not display after signing it Web/mweb - Chat - Chat list does not display after signing in Sep 15, 2022
@johnmlee101
Copy link
Contributor

This happens while OpenApp is processing, and the result of OpenApp looks fine, so its the render that follows thats failing?

@francoisl
Copy link
Contributor

I can consistently reproduce on web with the account applausetester+0901abb@applause.expensifail.com. Should we just revert #10784 for now?

@luacmartins
Copy link
Contributor

@francoisl can we confirm that reverting #10784 fixes the issue?

@francoisl
Copy link
Contributor

No because I don't think anyone was able to reproduce the issue in dev in the first place, but the idea is:

@johnmlee101
Copy link
Contributor

We'd have to revert the CP as well if we go this route, right?

@francoisl
Copy link
Contributor

Yes we'd either revert the CP first, or there would be a conflict if we directly revert #10784. We can do both reverts in one PR though, it's not really a problem.

@johnmlee101 johnmlee101 added Reviewing Has a PR in review and removed Reviewing Has a PR in review labels Sep 15, 2022
@johnmlee101
Copy link
Contributor

Okay I'd say to prevent blocking another deploy let's do that. Order of operations is

  1. Create the revert for Omit default Avatar param to prevent crash on app start #11006
  2. Add the revert for Optimize report ordering in the LHN #10784 into the mix
  3. CP to staging label
  4. Test

Correct?

@francoisl
Copy link
Contributor

Yes and we can make steps 1 and 2 in one PR - give me a second to double check.

@francoisl francoisl self-assigned this Sep 15, 2022
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Sep 15, 2022
@francoisl
Copy link
Contributor

We can reproduce this in production too - it might be related to a recent Web-E change though, let's keep this open as a high-priority issue.

@francoisl francoisl added the Daily KSv2 label Sep 15, 2022
@luacmartins
Copy link
Contributor

lol why does Melvin keep assigning internal engineers? Am I the CME for this issue?

@mallenexpensify
Copy link
Contributor

Yeah, @luacmartins , you're the CME, John and Francois aren't on the CME team.

@Christinadobrzyn Christinadobrzyn changed the title [$250] Web/mweb - Chat - Chat list / LHN does not display after signing in [$250] Web/mweb - Chat - LHN does not display after signing out/signing in Oct 5, 2022
@Christinadobrzyn
Copy link
Contributor

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2022
@Christinadobrzyn
Copy link
Contributor

Waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2022

@francoisl, @johnmlee101, @eVoloshchak, @luacmartins, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor

Gonna move this to a weekly while we wait for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2022
@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Oct 11, 2022
@Christinadobrzyn Christinadobrzyn changed the title [$250] Web/mweb - Chat - LHN does not display after signing out/signing in [$500] Web/mweb - Chat - LHN does not display after signing out/signing in Oct 17, 2022
@Christinadobrzyn
Copy link
Contributor

Doubling price to $500

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2022
@Christinadobrzyn Christinadobrzyn changed the title [$500] Web/mweb - Chat - LHN does not display after signing out/signing in [$1000] Web/mweb - Chat - LHN does not display after signing out/signing in Oct 25, 2022
@Christinadobrzyn
Copy link
Contributor

doubled price - still waiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 2, 2022
@luacmartins
Copy link
Contributor

Still looking for proposals

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2022
@Christinadobrzyn Christinadobrzyn changed the title [$1000] Web/mweb - Chat - LHN does not display after signing out/signing in [$2000] Web/mweb - Chat - LHN does not display after signing out/signing in Nov 3, 2022
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Nov 3, 2022

Price doubled $2000 - still waiting on proposals

@luacmartins
Copy link
Contributor

I'm unable to reproduce this. @kbecciv could you please ask the team to try to reproduce on the latest build?

@kbecciv
Copy link
Author

kbecciv commented Nov 4, 2022

Issue is not reproduced in build v1.2.23-9

Recording.1611.mp4

@luacmartins
Copy link
Contributor

Thanks @kbecciv! Ok, I'm gonna close this since we can't reproduce the issue. My guess is that the performance improvements we made to the LHN fixed this somehow. Please reopen if this happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.