Deploy Checklist: New Expensify 2022-09-13

[OSBotify]

Release Version: 1.2.0-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix the native link renderer #10503
• Add offline behavior and error handling for AcceptWalletTerms #10578
• Optimize report ordering in the LHN #10784
• fix crash on DetailsPage #10820
• Center loading indicator #10823
• Refactor withFullPolicy #10873
• [No QA] Update Onyx Fields When Creating Workspace #10874
• fix: web banner cut off #10879
• [No QA] Revert "Toggle staging and production server api" #10920
• Toggle staging and production server api #10935
• Return early if policy doesn't have customUnits to prevent crash #10937
• adding screen listener to participants page #10938
• CP a useless commit to fix failed release #10942
• [No QA][Refactor] Add helper method to build Onyx data for VBBA setup #10954
• Remove usages of onyxRates #10974
• Revert "Refactor withFullPolicy" #10979
• Add missing code from main into staging branch #10995
• Dummy change to allow new staging CP #11000
• Omit default Avatar param to prevent crash on app start #11006
• Use existing personal details' avatar when it exists #11022
• Add missing alternateText option in option #11023
• Only use personal detail login as alternateText if we're not making the option for a report #11029

Deploy Blockers:

• Custom units are broken #10978
• Android - Chat - App crashed after sign in with specific account #11003
• [$2000] Web/mweb - Chat - LHN does not display after signing out/signing in #11011
• All workspace member are showing with green avatar - Reported by @thesahindia #11019
• All workspace members are showing with green avatar #11020
• No emails are shown on the member Invite page - Reported by @parasharrajat #11021

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[mountiny]

Checking #10937 off as that has already been QA'ed in the previous version

[Julesssss]

@Expensify/applauseleads the automated message failed to post, but all platform builds should now be available for testing.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.0-0 🚀

[mvtglobally]

@francoisl @Julesssss Regression is almost completed

PR #10820 is failing due to #10966
PR #10935 is failing due to #10963 & #10970

[jasperhuangg]

Just noticed that custom units are currently broken on staging but not on prod.. investigating

Screen.Recording.2022-09-13.at.2.01.02.PM.mov

cc @Julesssss @mvtglobally @francoisl

[jasperhuangg]

Are there any other deploy checklists that haven't hit prod yet?

[jasperhuangg]

Looks like reverting #10873 locally fixes things. I say we revert it on staging too.

cc @arosiclair

[mvtglobally]

There were couple issues logged around this area. Not sure if this related #10877

[jasperhuangg]

There were couple issues logged around this area. Not sure if this related #10877

Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

cc @mvtglobally

[francoisl]

PR #10820 is failing due to #10966

That one was already crashing in production, so no need to block the deploy on it.

PR #10935 is failing due to #10963 & #10970

Look into those

Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

@jasperhuangg thanks for looking. I'm trying to reproduce locally and see if there's a simple fix we could CP. Otherwise, let's revert that PR.

[mvtglobally]

@francoisl @jasperhuangg do you need a new issue created for this blocker?

[jasperhuangg]

@mvtglobally #10978 already created one, feel free to update it to look better since I rushed to create it

[jasperhuangg]

Let's continue discussion for a fix on there? @francoisl

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-1 🚀

[francoisl]

I tested the 1.2.0-1 CP above, which fixes #10978 and also checks off #10979.

#10942 is No QA, checking it as well.

[francoisl]

The last item is #10935, but it fails QA because the code for that PR is not on staging 😕. It seems to be a similar issue with cherry-picks as we had a few weeks ago. I'm not sure how to resolve it at the moment, asked for opinions in Slack here.

[mvtglobally]

@francoisl How does it look like so far? Let us know if anything needs to be re-tested

[francoisl]

We're working on fixing the staging branch. We're having the same issue as ~1 month ago where some code wasn't merged into the branch correctly.
Heads up that the fix will cause a few more PRs to be added to the checklist, but I don't expect it will be 100+ PRs like last time :D

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-3 🚀

[francoisl]

@mvtglobally thanks for your patience while we work through the deploy issues 🙌

The new version 1.2.0-3 should include all the expected changes. At the moment, it's deployed to web, desktop and Android. iOS is still in progress, it's possible that it will time out again like yesterday, but hopefully you should still receive a notification to install the new testflight manually (following the flow here).

I double-checked and confifmed on web that #10935 is now passing.

However, I think the checklist is missing a few new PRs that were merged earlier today and yesterday - I'm checking that right now and will post an update in a bit. In the meantime, feel free to continue QAing #10935 on other platforms.

[francoisl]

Ok @mvtglobally there are 4 new PRs to check, I updated the checklist above (there were also 2 with no QA needed, I directly checked them). Feel free to start testing.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-3 has been deployed to staging 🎉

[mvtglobally]

Still working on the new PRs.
Will have update in the morning
So far PR #10784 is failing due to #10423

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-4 🚀

[Julesssss]

I just CP'd this PR which is a fix for the remaining deployBlocker

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-4 has been deployed to staging 🎉

[mvtglobally]

PR #11006 is failing #11011

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-5 🚀

[mvtglobally]

Checking off #10935

[francoisl]

Cool. #10974 should be good to go as well.

We're considering reverting #10784 in order to fix the last blocker, which would also automatically revert #11006 and thus check the two remaining items.

[mvtglobally]

Outstanding items

So far PR #10784 is failing due to #10423. Ok to check off?

PR #11006 is failing #11011

PR #10974 are you checking internally already?

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-5 has been deployed to staging 🎉

[francoisl]

Let's not check #10784 just yet - we're still discussing reverting it. It should then also resolve #11006.

---

PR #10974 are you checking internally already?

We tested on web only, can you test on the other platforms please?

[luacmartins]

Tested #10974 and it's a pass. Checking it off.

[francoisl]

We reproduced #11011 in production so we're going to remove the deployblocker label and keep it as a daily to be investigated.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-6 🚀

[francoisl]

There's going to be a 1.2.0-7 very shortly, please hang on a second.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-7 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-7 has been deployed to staging 🎉

[francoisl]

Sorry - hang on for a few more moments, we found an issue with one of the fixes 😅 We made a fix already, so the version to test will be 1.2.0-8. It should start being deployed shortly.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-8 🚀

[francoisl]

#11022 and #11029 are 👍 on Web, Desktop and Android, just waiting on iOS.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-8 has been deployed to staging 🎉

[francoisl]

@chiragsalian was able to test #11022 and #11029 on iOS so we're all set!

[francoisl]