Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy change to allow new staging CP #11000

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Dummy change to allow new staging CP #11000

merged 1 commit into from
Sep 14, 2022

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Sep 14, 2022 •
edited
Loading

Details

Follow-up of #10998 with an actual code change. It looks like this workflow failed because there were no changes at all.

QA

No QA

@francoisl francoisl requested a review from a team as a code owner September 14, 2022 20:33
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team September 14, 2022 20:33
@francoisl francoisl self-assigned this Sep 14, 2022
@tgolen tgolen merged commit 285893b into main Sep 14, 2022
@tgolen tgolen deleted the francois-dummyCommitStagingCPRound2 branch September 14, 2022 20:35
@melvin-bot melvin-bot bot added the Emergency label Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 14, 2022

@tgolen looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@tgolen tgolen removed the Emergency label Sep 14, 2022
@francoisl
Copy link
Contributor Author

Not an emergency - this PR doesn't introduce logic changes, and we need it to trigger a new staging deploy, so we omitted the author and Contributor+ checklists.

OSBotify pushed a commit that referenced this pull request Sep 14, 2022
@tgolen @OSBotify
Merge pull request #11000 from Expensify/francois-dummyCommitStagingC…
3741e17 
…PRound2

Dummy change to allow new staging CP

(cherry picked from commit 285893b)
@OSBotify OSBotify mentioned this pull request Sep 14, 2022
Merged
OSBotify added a commit that referenced this pull request Sep 14, 2022
@OSBotify
Merge pull request #11002 from Expensify/OSBotify-cherry-pick-staging…
6c283ae 
…-11000

🍒 Cherry pick PR #11000 to staging 🍒
@OSBotify OSBotify mentioned this pull request Sep 14, 2022
Closed
30 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @tgolen in version: 1.2.0-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Sep 16, 2022
Closed
27 tasks
@OSBotify OSBotify mentioned this pull request Oct 14, 2022
Closed
53 tasks
@OSBotify OSBotify mentioned this pull request May 2, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

@luacmartins luacmartins luacmartins approved these changes

@arosiclair arosiclair Awaiting requested review from arosiclair

Assignees

@francoisl francoisl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisl @OSBotify @tgolen @luacmartins