Mileage rate is 0.00 for the newly created workspace instead of the rate set in the policy

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #10692

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Create a New Workspace
3. Go to to Settings -> [Workspace] -> Reimburse expenses
4. Try to change the mileage rate and the mi/km selector

Expected Result:

1. Mileage rate should display the value you have in your policy
2. The mileage rate should be editable
3. The miles/km selector must be operational

Actual Result:

1. A new workspace is created with 0.00 milage rate (the rate is set in this policy)
2. When you try to edit the mileage rate, you get an error
3. Cannot change miles to kilometers

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Mobile Web

Version Number: v1.1.97-7
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+ihchat4@applause.expensifail.com / Yulia1986Gerets
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: https://user-images.githubusercontent.com/43996225/188964955-fd47cd77-6122-44e9-b33b-956300963889.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

Damn, this is a new regression occurring from another blocker fix.

@Expensify/mobile-deployers

[yuwenmemon]

Looks like the workspace is undefined in Onyx when we first create it?

When I refresh the page and open the page again, the mileage rate shows and can be updated:

[yuwenmemon]

Oh, interesting. The PolicyID changed for the workspace...

[yuwenmemon]

Actually wait no, I think the problem is that there are two custom units on the initially created policy...

[yuwenmemon]

So somewhere we're not keying the customUnit by the ID when we update Onyx 🤔

[yuwenmemon]

I would guess it's this line:

App/src/libs/actions/Policy.js

Line 90 in 367b662

customUnits: lodashGet(fullPolicyOrPolicySummary, 'value.customUnits', {}),

[yuwenmemon]

Hm no actually it's coming from the CreateWorkspace API command:

[yuwenmemon]

Hm yeah - so the problem is that the structure with which we hold Custom Units in OldDot is as an array:

But in NewDot we want it to be an object keyed by the CustomUnitID:

[yuwenmemon]

Ah yep, so @amyevans @jasperhuangg we just missed one spot here - we also want to do the data massaging we do in Getting the policy when we Create the policy as well.

[Julesssss]

Thanks so much, this works perfectly 😍

Fixed.mov

[amyevans]

Oh goodness, thanks for fixing @yuwenmemon and @Julesssss ❤️