Deploy Checklist: New Expensify 2022-09-05

[OSBotify]

Release Version: 1.1.97-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Frenkield 8595 pdf password #9141
• Add test to check for Contributor and Contributor+ Checklists #9772
• [No QA] Update to Webpack 5 and peer dependencies  #10286
• Use window.location.href for current URL #10494
• Refactor custom unit rate update  #10557
• Fix search bug in IOU currency selector #10613
• Refactor of WorkspaceReimburseView to use new API #10692
• Fix cursor in image modal #10695
• Clear 2FA code from state when going back to login form #10702
• Lower case file extension for validation #10730
• Remove unreadActionCount & Improve Global Indicators #10739
• Add offline UX for workspace #10749
• Fix for delete comment refactor #10764
• Revert "update react-native-svg version" #10775
• Use sequenceNumber and reportActionID for now #10779
• Show deleted messages with a strike-through when offline #10780
• Add resendLink message to successData #10783
• Follow up for checklist PR #10788
• Use node 16 in all GitHub actions #10791
• [No QA] Fix some propType warnings #10797
• Cleanup from #10749 #10809
• [NO QA] Update iOS cert and provisioning profile #10844
• [No QA] Fetch full PR object to fix CPs #10856
• Attempt to workaround a workflow CP edge case #10867

Deploy Blockers:

• Reimburse expenses - The milage rate automatically changes to the initial value #10821
• Android - Attachment - PDF password form displayed lower than expected #10822
• Android - Workspace settings - Input fields are not grayed out when made changes offline #10825
• [$250] Android - App crashed when try to split bill for group. #10826
• mWeb - Global Unread Indicator - Global Unread Indicator doesn't decreases #10828
• Android - Global Unread Indicator - There is no Global Unread Indicator in Android App #10829
• Mileage rate is 0.00 for the newly created workspace instead of the rate set in the policy #10877

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.97-2 🚀

[mvtglobally]

@Julesssss still waiting for IOS build. Rest is almost completed

[Julesssss]

Two blockers, but they don't seem too problematic. Will chase up the iOS build and work on the blockers after lunch

[Julesssss]

The iOS release is blocked, but this is being resolved internally. Will share an update later.

[AndrewGable]

Agreed ☝️

[Julesssss]

I removed 10826 as a blocker because it is only affecting high-traffic Android devices, and even then has not been reproduced by us yet. Made the issue external and we'll continue to investigate.

[Julesssss]

I just finished updating the Apple certs and provisioning profile, and we're awaiting the CP to see if the iOS build is successfull. This will hopefully unblock iOS Applause testing soon 🤞

[Julesssss]

Unfortunately, I ran into a different error when running the CP. I wonder if it would make sense to begin a regression test on all platforms excluding iOS in the meantime, to save a bit of time tomorrow?

[Julesssss]

Created a new issue for the CP issue here

[mvtglobally]

@Julesssss All other platforms are done, we are just waiting for IOS to finish this run

[Julesssss]

Ah that's great, I hadn't had a chance to review individual issues. In that case there's nothing else we can do until tomorrow morning, unfortunately. I'll be treating the iOS release blocker as a fire and will give you an update as soon as possible!

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.97-6 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.97-6 has been deployed to staging 🎉

[Julesssss]

iOS is still blocked, but shouldn't be too far away now 🤞

[Julesssss]

iOS build has been uploaded to Testflight and should be available soon. After this, there will be one more staging release which should follow shortly.

[mvtglobally]

@Julesssss i can see build 1.1.97-4 in TestFlight. Are we ok to resume IOS?

[Julesssss]

Hey @mvtglobally, there should be another iOS build released very shortly. I'll confirm the exact version shortly

[Julesssss]

Hi again @mvtglobally. Unfortunately a 3rd issue has blocked the release for a moment. Could you please start testing against version 1.1.97-4 in the meantime, to ensure we're not too delayed? Thanks!

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.97-7 🚀

[Julesssss]

Hey @mvtglobally, this is the release we've been waiting for. Please go ahead and restart testing against this build

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.97-7 has been deployed to staging 🎉

[Julesssss]

Hey @Expensify/applauseleads. Please restart testing when ready. All platforms are ready

[mvtglobally]

@Julesssss We are almost done. Will share summary in a few
7% test rail pending and couple IOS PRs

[mvtglobally]

@Julesssss Interim summary.

PR #9772 Can you validate internally
PR #10494 is blocked partially on mWeb due to #10282. Are we ok to check off?
PR #10692 is failing due to #10821. Re-testing
PR #10739 just retesting IOS
PRs #10809 & #10749 are dependent on the Web deploy. https://github.com/Expensify/Expensify/issues/224690. Are we ok to check off?

[Julesssss]

Marking off #9772

[chiragsalian]

PR #10494 is blocked partially on mWeb due to #10282. Are we ok to check off?

Yes checking off #10494 since it looks like its not supported on mobile atm.

[mvtglobally]

@Julesssss @chiragsalian Can you also help out with #10557 It seems we are not able to trigger the error in staging same way to check

[chiragsalian]

Checking off #10692. Its working great for me on staging.

[Julesssss]

I also think this should be tested: #10749

And we can check off this one: https://github.com/Expensify/Expensify/issues/224690

[chiragsalian]

Checking off #10557. It works well for me. Unfortunately, there is no easy way to test the errors part so its okay to skip that bit for now.

[Julesssss]

#10282 can be checked off, but I don't see it in the list, and it's not merged. Not sure why that was listed

[Julesssss]

Ah, my mistake. It's linked to by 10809 and 10749

[chiragsalian]

Both #10692 and #10821, work great for me on staging. @mvtglobally, if it helps maybe you need to sign out and sign in to re-test them.

[mvtglobally]

#10692 #10692 (comment) @chiragsalian , Not sure if this is related to #10557 changed. Not repro by all testers, so we are still checking

[mvtglobally]

#10780 We are facing #10753. It was closed. Are we ok to check it off or log again?

https://user-images.githubusercontent.com/43995119/188957911-d414785b-a84b-4462-9a0b-5e79151f5dcc.mp4
https://user-images.githubusercontent.com/43995119/188957912-961899f1-b4a2-4d71-bfd2-eb146c253715.mp4

[chiragsalian]

#10780 We are facing #10753. It was closed. Are we ok to check it off or log again?

Can you log it as an issue. I don't think its deploy blocker worthy though.

[Julesssss]

Just checked off the last blocker (10821), and added a screencast of the resolved issue.

[mvtglobally]

Ok, so latest summary

#10739 - just finishing IOS. Rest is ok
PRs testing #10749 not waiting on the Web deploy of https://github.com/Expensify/Expensify/issues/224690. What do we do with #10809?
PR ##10780 logging an issue non-blocker. will check off once all platforms re-tested

[mvtglobally]

1 more note. Some non-US testers did not receive new IOS build. I have just 2 slots pending in Test Rail for IOS 16 BETA (since those testers dont have build yet). We tested exact same steps on IOS 15/14. Let me know if you want to wait for build or we ok this time
https://expensify.testrail.io/index.php?/plans/view/8805

[Julesssss]

I marked off #10809 as it cannot be tested yet... we're waiting on a Web-E PR.

[Julesssss]

@mvtglobally excellent, thanks for the update. Let's wait for the remaining Apple invite. I'm happy to try resending manually if you have the email to hand.

[mvtglobally]

Sent you details in Slack @Julesssss

[mvtglobally]

#10877 when running #10692

[Julesssss]

#10877 when running #10692

@chiragsalian would you mind taking a look at this today if you have a moment. Thanks 🙏

[Julesssss]

Checking off #10749 because it's dependent on another PR that isn't merged.

[Julesssss]

Checking off #10739 which tested flawlessly.

[Julesssss]

No new crashes, marking off Firebase

[Julesssss]

Some non-US testers did not receive new IOS build. I have just 2 slots pending in Test Rail for IOS 16 BETA (since those testers dont have build yet). We tested exact same steps on IOS 15/14. Let me know if you want to wait for build or we ok this time

We discussed this internally and are happy to move forward given that we don't see any users on this specific iOS beta version.

[Julesssss]

Closed the final remaining blocker 10877. Thanks so much, @yuwenmemon & @chiragsalian for your help.

[Julesssss]