Remove usages of `onyxRates` #10974

jasperhuangg · 2022-09-13T20:03:32Z

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/226121

Tests/QA Steps

You'll need the changes from https://github.com/Expensify/Web-Expensify/pull/34842 to test

Open or create a workspace.
Navigate to "Reimburse expenses".
Update the custom unit rate. Click back, and reopen this page. Verify the changes are persisted correctly.
Refresh the page, and verify the changes are persisted correctly.

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

…xRates

neil-marcellini · 2022-09-15T15:55:15Z

Reviewing now 👀

neil-marcellini

The code looks good, but it's not testing well for an existing workspace. I'm not able to update the rate and there's a console error. Check out this video:

Screen.Recording.2022-09-15.at.9.13.52.AM.mov

I think the problem is that OpenWorkspaceReimburseView is still returning the rates as an array in Web here.

…xRates

jasperhuangg · 2022-09-15T16:35:32Z

The code looks good, but it's not testing well for an existing workspace. I'm not able to update the rate and there's a console error. Check out this video:

Screen.Recording.2022-09-15.at.9.13.52.AM.mov
I think the problem is that OpenWorkspaceReimburseView is still returning the rates as an array in Web here.

@neil-marcellini Ohhh that's bizarre, things were working last time I tested. I just pulled main on Web-Expensify and App and tested, and things appear to be working as expected. I think the OpenWorkspaceReimburseView changes were reverted recently, can you pull main on both those repos and try again?

Screen.Recording.2022-09-15.at.9.32.16.AM.mov

github-actions · 2022-09-15T16:36:41Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

jasperhuangg · 2022-09-15T16:36:46Z

Adding the CP Staging label to unblock #10978 sooner

mountiny

LGTM! We got the Web-PR in Staging now.

neil-marcellini

Tests well after https://github.com/Expensify/Web-Expensify/pull/34862, which will be CPed to staging.

mountiny

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-09-15T17:25:36Z

@jasperhuangg looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

jasperhuangg · 2022-09-15T17:26:19Z

Was merged before it could complete the checklist check, but complete checklist was posted here, removing Emergency label.

Remove usages of `onyxRates` (cherry picked from commit 05f41cb)

…-10974 🍒 Cherry pick PR #10974 to staging 🍒

francoisl · 2022-09-15T17:48:19Z

Did we really need to CP this PR? We had already reverted the PR that cause the issue, so it was just waiting on Applause to finish testing.

jasperhuangg · 2022-09-15T17:52:11Z

@francoisl With this code, the PR that was reverted should now work. I figured we would get it CP'd to staging so that #10978 wouldn't be held on this and @arosiclair could get to testing and deploying faster.

Sorry of this wasn't the right move! I guess I just wanted to speed things along since I felt kinda bad for forcing the revert on #10979

jasperhuangg · 2022-09-15T17:57:32Z

Just tested on staging and everything is working as expected

Screen.Recording.2022-09-15.at.10.54.41.AM.mov

cc @neil-marcellini

OSBotify · 2022-09-15T18:39:18Z

🚀 Cherry-picked to staging by @jasperhuangg in version: 1.2.0-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-15T01:46:16Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

remove usages of onyxRates

0a84843

jasperhuangg self-assigned this Sep 13, 2022

jasperhuangg changed the title ~~Remove usages of onyxRates~~ Remove usages of onyxRates Sep 13, 2022

jasperhuangg changed the title ~~Remove usages of onyxRates~~ [HOLD Web-Expensify#34842] Remove usages of onyxRates Sep 13, 2022

jasperhuangg requested a review from chiragsalian September 13, 2022 20:11

jasperhuangg marked this pull request as ready for review September 13, 2022 20:11

jasperhuangg requested a review from a team as a code owner September 13, 2022 20:11

melvin-bot bot requested review from neil-marcellini and removed request for a team September 13, 2022 20:11

Merge branch 'main' of github.com:Expensify/App into jasper-removeOny…

0c6a87d

…xRates

neil-marcellini requested changes Sep 15, 2022

View reviewed changes

jasperhuangg mentioned this pull request Sep 15, 2022

Custom units are broken #10978

Closed

Merge branch 'main' of github.com:Expensify/App into jasper-removeOny…

f841732

…xRates

jasperhuangg added the CP Staging label Sep 15, 2022

jasperhuangg requested a review from neil-marcellini September 15, 2022 16:36

mountiny approved these changes Sep 15, 2022

View reviewed changes

mountiny changed the title ~~[HOLD Web-Expensify#34842] Remove usages of onyxRates~~ Remove usages of onyxRates Sep 15, 2022

neil-marcellini approved these changes Sep 15, 2022

View reviewed changes

mountiny approved these changes Sep 15, 2022

View reviewed changes

jasperhuangg merged commit 05f41cb into main Sep 15, 2022

jasperhuangg deleted the jasper-removeOnyxRates branch September 15, 2022 17:25

melvin-bot bot added the Emergency label Sep 15, 2022

jasperhuangg removed the Emergency label Sep 15, 2022

OSBotify pushed a commit that referenced this pull request Sep 15, 2022

Merge pull request #10974 from Expensify/jasper-removeOnyxRates

adb83a2

Remove usages of `onyxRates` (cherry picked from commit 05f41cb)

OSBotify mentioned this pull request Sep 15, 2022

🍒 Cherry pick PR #10974 to staging 🍒 #11016

Merged

OSBotify added a commit that referenced this pull request Sep 15, 2022

Merge pull request #11016 from Expensify/OSBotify-cherry-pick-staging…

f4f6a28

…-10974 🍒 Cherry pick PR #10974 to staging 🍒

OSBotify mentioned this pull request Sep 15, 2022

Deploy Checklist: New Expensify 2022-09-13 #10958

Closed

30 tasks

OSBotify mentioned this pull request Sep 16, 2022

Deploy Checklist: New Expensify 2022-09-16 #11043

Closed

27 tasks

kbecciv mentioned this pull request Sep 16, 2022

Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

Closed

OSBotify mentioned this pull request Oct 14, 2022

Deploy Checklist: New Expensify 2022-10-14 #11873

Closed

53 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove usages of `onyxRates` #10974

Remove usages of `onyxRates` #10974

jasperhuangg commented Sep 13, 2022 •

edited

Loading

neil-marcellini commented Sep 15, 2022

neil-marcellini left a comment

jasperhuangg commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

mountiny left a comment

neil-marcellini left a comment

mountiny left a comment

melvin-bot bot commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

francoisl commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

OSBotify commented Sep 15, 2022

OSBotify commented Jun 15, 2023

Remove usages of onyxRates #10974

Remove usages of onyxRates #10974

Conversation

jasperhuangg commented Sep 13, 2022 • edited Loading

Fixed Issues

Tests/QA Steps

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

neil-marcellini commented Sep 15, 2022

neil-marcellini left a comment

Choose a reason for hiding this comment

jasperhuangg commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

mountiny left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

francoisl commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

jasperhuangg commented Sep 15, 2022

OSBotify commented Sep 15, 2022

OSBotify commented Jun 15, 2023

Remove usages of `onyxRates` #10974

Remove usages of `onyxRates` #10974

jasperhuangg commented Sep 13, 2022 •

edited

Loading