Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

kbecciv · 2022-09-16T14:57:11Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #10974

Action Performed:

Open the App and login with any account
Go to Settings->Workspace->Reimburse expenses
Try entering more than three digits after the period. You may need to close the program before that

Expected Result:

It is not possible to enter more than three digits after a dot (comma)
The rate should not reset and the error should not appear

Actual Result:

The system is allow entering more than three digits after a dot (comma)
Error message displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

Android

Version Number: 1.2.1.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5734721_10468_Android_FAIL.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify · 2022-09-16T14:58:29Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2022-09-16T14:58:32Z

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Justicea83 · 2022-09-16T15:19:24Z

This can be external

melvin-bot · 2022-09-16T15:20:10Z

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

luacmartins · 2022-09-16T15:28:02Z

@Justicea83 this is a deploy blocker and should be handled internally because of urgency in the fix. Removing the External label.

Justicea83 · 2022-09-16T15:30:00Z

Ohk, thanks for picking it up, wraping up here

luacmartins · 2022-09-16T16:56:14Z

I can reproduce inputting more than 3 digits on android and iOS, however I could not reproduce the error message nor the value being reset to 0.

francoisl · 2022-09-16T17:18:58Z

Interesting, have you managed to identify a clear pattern of when it happens? I'm trying the same exact steps as the video and randomly minimizing/reopening the app but can't reproduce (on Android). I wonder if it could have something to do with this PR: #10468.

luacmartins · 2022-09-16T17:21:31Z

The error message suggests that the policy has been updated while we were offline, so maybe going offline and editing the policy on OldDot would trigger the error?

I'm triggering that error on dev, but the rate is reset to the original amount after the call fails and the error is shown.

luacmartins · 2022-09-16T17:35:30Z

@kbecciv we are having issues reproducing the rate being reset to 0. Is this consistently reproducible for you?

Santhosh-Sellavel · 2022-09-16T18:01:43Z

I wonder if it could have something to do with this PR: #10468.

I believe not, I didn't experience anything even close to this!

It is not possible to enter more than three digits after a dot (comma)

Is this the expected, as far as I know we will round off to three digits.

The rate should not reset and the error should not appear

This is issue due to internet failure. Turn off internet try changing values after some time resume internet I see 0.000 and error even on iOS check out the video below.

RPReplay_Final1663351187.MP4

@francoisl @luacmartins hope this clarifies, thanks!

kbecciv · 2022-09-16T18:05:22Z

@luacmartins Yes, two testers was able to reproduce it.

Screen_Recording_20220916-084224_New.Expensify.mp4

Santhosh-Sellavel · 2022-09-16T18:18:24Z

I checked the recent android build, it always gets reset to 0.000

luacmartins · 2022-09-16T20:10:48Z

I was able to reproduce reliably as well, but I also see the problem in prod. I'll remove the blocker label and make this an external issue.

luacmartins · 2022-09-16T20:11:50Z

Actually, I'll keep this one internal since it might involve the new API command.

luacmartins · 2022-10-03T23:10:08Z

I did some testing and it seems like that issue 1, is caused by the delay between the input and setState re-rendering the component on mobile. In the past, we got around this by using setNativeProps but we are migrating away from that to enable Fabric. I'll explore other options.

luacmartins · 2022-10-03T23:15:37Z

I see this in the logs:

 WARN  Please report: Excessive number of pending callbacks: 501. Some pending callbacks that might have leaked by never being called from native code: {"82":{},"51174":{"module":"ReactNativeBlobUtil","method":"emitExpiredEvent"},"51574":{},"51576":{},"51578":{},"51580":{},"51582":{},"51584":{},"51586":{},"51588":{},"51590":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51592":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51594":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51596":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51598":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51600":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51602":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51604":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51606":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51608":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51610":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51612":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51614":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51616":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51618":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51620":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51663":{"module":"ReanimatedModule","method":"getValue"},"51714":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51716":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51959":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51962":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51965":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51968":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51971":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51974":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51977":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51980":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51983":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51986":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51989":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51992":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51995":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"51998":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52001":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52004":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52007":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52010":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52013":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52016":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"52019":{"module":"NativeAnimatedModule","method":"startAnimatingNode"},"...(truncated keys)...":451} 
    at TouchableOpacity (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:91101:36)
    at TouchableOpacity
    at RCTView
    at View
    at Hoverable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:262981:70)
    at OptionRowLHN (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:356409:63)
    at withLocalize(OptionRowLHN)
    at RCTView
    at View
    at VirtualizedListCellContextProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:100945:24)
    at CellRenderer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:98352:36)
    at RCTScrollContentView
    at RCTScrollView
    at ScrollView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:98648:36)
    at ScrollView
    at VirtualizedListContextProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:100919:25)
    at VirtualizedList (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:97000:36)
    at FlatList (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:96348:36)
    at RCTView
    at View
    at LHNOptionsList (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:356272:36)
    at RCTView
    at View
    at SidebarLinks (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:355939:36)
    at withOnyx(SidebarLinks) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withWindowDimensions(Component)
    at WithCurrentUserPersonalDetails(withWindowDimensions(Component)) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273363:35)
    at withOnyx(Component) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withLocalize(Component)
    at RCTView
    at View
    at RCTView
    at View
    at LoginKeyboardAvoidingView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:102408:36)
    at RCTView
    at View
    at BaseScreenWrapper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:275482:36)
    at withNetwork(BaseScreenWrapper)
    at withOnyx(withNetwork(BaseScreenWrapper)) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withWindowDimensions(Component)
    at withNavigation(withWindowDimensions(Component)) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273104:101)
    at ScreenWrapper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:275399:22)
    at BaseSidebarScreen (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:355673:36)
    at withDrawerState(BaseSidebarScreen) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:347342:105)
    at SidebarScreen
    at withOnyx(SidebarScreen) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withWindowDimensions(Component)
    at withLocalize(withWindowDimensions(Component))
    at withNavigation(withLocalize(withWindowDimensions(Component))) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273104:101)
    at RCTView
    at View
    at AnimatedComponent(View) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:119102:38)
    at RCTView
    at View
    at AnimatedComponent(View) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:119102:38)
    at PanGestureHandler (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:113303:38)
    at PanGestureHandler (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:349813:34)
    at DrawerView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:349926:36)
    at DrawerViewBase (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:347616:22)
    at RCTView
    at View
    at GestureHandlerRootView
    at RCTView
    at View
    at SafeAreaProviderCompat (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:254307:25)
    at DrawerView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:347836:27)
    at anonymous (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:219162:24)
    at DrawerNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:347493:32)
    at BaseDrawerNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:357143:36)
    at withWindowDimensions(BaseDrawerNavigator)
    at MainDrawerNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:344438:59)
    at withOnyx(MainDrawerNavigator) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at StaticContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:219454:17)
    at EnsureSingleNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:215146:24)
    at SceneView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:219359:22)
    at RCTView
    at View
    at RCTView
    at View
    at RCTView
    at View
    at CardSheet (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258005:23)
    at RCTView
    at View
    at AnimatedComponent (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:95547:38)
    at AnimatedComponentWrapper
    at PanGestureHandler (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:113303:38)
    at PanGestureHandler (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258092:34)
    at RCTView
    at View
    at AnimatedComponent (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:95547:38)
    at AnimatedComponentWrapper
    at RCTView
    at View
    at Card (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:257433:36)
    at CardContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:257027:34)
    at RNSScreen
    at AnimatedComponent (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:95547:38)
    at AnimatedComponentWrapper
    at MaybeFreeze (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258318:23)
    at Screen (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258365:36)
    at MaybeScreen (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258161:24)
    at RNSScreenContainer
    at ScreenContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258484:31)
    at MaybeScreenContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:258146:23)
    at RCTView
    at View
    at Background (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:253027:21)
    at CardStack (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:254563:36)
    at RCTView
    at View
    at SafeAreaProviderCompat (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:254307:25)
    at RCTView
    at View
    at GestureHandlerRootView
    at StackView (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:252030:36)
    at CustomRootStackNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:250962:24)
    at AuthScreens (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:250403:36)
    at withOnyx(AuthScreens) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withWindowDimensions(Component)
    at AppNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:250246:14)
    at EnsureSingleNavigator (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:215146:24)
    at BaseNavigationContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:214695:28)
    at ThemeProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:220794:21)
    at NavigationContainerInner (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:220670:26)
    at NavigationRoot (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:250171:36)
    at Expensify (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:249938:36)
    at withOnyx(Expensify) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withLocalize(Component)
    at BaseErrorBoundary (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:169833:36)
    at WindowDimensionsProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:250691:36)
    at RenderersPropsProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:298113:44)
    at ListStyleSpecsProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:299624:25)
    at SharedPropsProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:292626:53)
    at RenderRegistryProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:299106:24)
    at RenderHTMLConfigProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:298755:32)
    at TRenderEngineProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:298528:24)
    at BaseHTMLEngineProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:360250:14)
    at HTMLEngineProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:360166:19)
    at LocaleContextProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:221483:36)
    at withOnyx(LocaleContextProvider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at withOnyx(LocaleContextProvider)
    at RNCSafeAreaView
    at SafeArea (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:361593:22)
    at RNCSafeAreaProvider
    at SafeAreaProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:253586:24)
    at Private_blockedFromConciergeProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273254:21)
    at withOnyx(Private_blockedFromConciergeProvider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at CurrentDateProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273254:21)
    at withOnyx(CurrentDateProvider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at ReportActionsDrafts_Provider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273254:21)
    at withOnyx(ReportActionsDrafts_Provider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at PersonalDetailsProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273254:21)
    at withOnyx(PersonalDetailsProvider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at NetworkProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273254:21)
    at withOnyx(NetworkProvider) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:164229:40)
    at ComposeProviders (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273314:54)
    at OnyxProvider (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273208:22)
    at ComposeProviders (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:273314:54)
    at RCTView
    at View
    at GestureHandlerRootView
    at App
    at RCTView
    at View
    at RCTView
    at View
    at AppContainer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:102950:36)
    at NewExpensify(RootComponent) (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.chat.expensify.chat:108745:28)

melvin-bot · 2022-10-03T23:15:40Z

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

luacmartins · 2022-10-12T14:26:38Z

I'm still focused on API refactors, but I have a hunch that we might be able to solve the 3 digits issue by using an uncontrolled input.

luacmartins · 2022-10-21T19:02:59Z

I'll try to get to this next week!

luacmartins · 2022-10-31T14:50:29Z

We have two distinct bugs here

On mobile, there's a delay between user input and component re-render, which makes it possible for the input to display more than 3 decimals. This should be fixed once we enable Fabric.
The rate is updated to a different value after coming back online. This should be fixed by this PR.

I'm gonna keep this issue open and monitor it to make sure it's solved.

mvtglobally · 2022-11-03T03:02:09Z

Issue not reproducible during KI retests. (First week)

luacmartins · 2022-11-03T18:16:02Z

I can't reproduce 1 anymore. Now we are down to offline edits being reset when we come back online which should be resolved by #12219

JmillsExpensify · 2022-11-03T18:21:25Z

Ok cool, so then I'll update the hold and re-test when that one is merged.

JmillsExpensify · 2022-11-06T20:20:55Z

Still waiting on #12219 to merge.

luacmartins · 2022-11-07T15:56:52Z

#12219 is merged. Gonna retest this.

luacmartins · 2022-11-07T19:19:32Z

This issue was fixed by #12219! 🎉

android.mov

Closing. Please reopen if needed.

JmillsExpensify · 2022-11-08T05:09:47Z

Oh nice! Thanks for jumping on that so quickly and testing!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 16, 2022

OSBotify mentioned this issue Sep 16, 2022

Deploy Checklist: New Expensify 2022-09-16 #11043

Closed

27 tasks

github-actions bot added Engineering Hourly KSv2 labels Sep 16, 2022

melvin-bot bot assigned Justicea83 Sep 16, 2022

Justicea83 added the External Added to denote the issue can be worked on by a contributor label Sep 16, 2022

melvin-bot bot assigned stephanieelliott Sep 16, 2022

Justicea83 unassigned Justicea83 and stephanieelliott Sep 16, 2022

luacmartins removed the External Added to denote the issue can be worked on by a contributor label Sep 16, 2022

luacmartins self-assigned this Sep 16, 2022

melvin-bot bot mentioned this issue Sep 16, 2022

[HOLD for payment 2022-09-26] [$250] User can't use , (comma) In spanish for decimals during IOU - reported by @thesahindia #9497

Closed

luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 16, 2022

melvin-bot bot removed the Overdue label Oct 3, 2022

luacmartins closed this as completed Oct 3, 2022

luacmartins reopened this Oct 3, 2022

melvin-bot bot added the Overdue label Oct 12, 2022

melvin-bot bot removed the Overdue label Oct 12, 2022

puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022

melvin-bot bot added the Overdue label Oct 21, 2022

melvin-bot bot removed the Overdue label Oct 21, 2022

melvin-bot bot added the Overdue label Oct 31, 2022

melvin-bot bot removed the Overdue label Oct 31, 2022

JmillsExpensify self-assigned this Nov 3, 2022

luacmartins added Daily KSv2 and removed Weekly KSv2 labels Nov 7, 2022

luacmartins closed this as completed Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

kbecciv commented Sep 16, 2022

OSBotify commented Sep 16, 2022

melvin-bot bot commented Sep 16, 2022

Justicea83 commented Sep 16, 2022

melvin-bot bot commented Sep 16, 2022

luacmartins commented Sep 16, 2022

Justicea83 commented Sep 16, 2022

luacmartins commented Sep 16, 2022

francoisl commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Sep 16, 2022

Santhosh-Sellavel commented Sep 16, 2022

kbecciv commented Sep 16, 2022

Santhosh-Sellavel commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Oct 3, 2022

luacmartins commented Oct 3, 2022

melvin-bot bot commented Oct 3, 2022

luacmartins commented Oct 12, 2022

luacmartins commented Oct 21, 2022

luacmartins commented Oct 31, 2022

mvtglobally commented Nov 3, 2022

luacmartins commented Nov 3, 2022 •

edited

Loading

JmillsExpensify commented Nov 3, 2022

JmillsExpensify commented Nov 6, 2022

luacmartins commented Nov 7, 2022

luacmartins commented Nov 7, 2022

JmillsExpensify commented Nov 8, 2022

Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

Android - Reimburse expenses - the rate value is reset to zero after the system allows entering more than three digits after the dot, error message displayed after. #11058

Comments

kbecciv commented Sep 16, 2022

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

OSBotify commented Sep 16, 2022

melvin-bot bot commented Sep 16, 2022

Justicea83 commented Sep 16, 2022

melvin-bot bot commented Sep 16, 2022

luacmartins commented Sep 16, 2022

Justicea83 commented Sep 16, 2022

luacmartins commented Sep 16, 2022

francoisl commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Sep 16, 2022

Santhosh-Sellavel commented Sep 16, 2022

kbecciv commented Sep 16, 2022

Santhosh-Sellavel commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Sep 16, 2022

luacmartins commented Oct 3, 2022

luacmartins commented Oct 3, 2022

melvin-bot bot commented Oct 3, 2022

luacmartins commented Oct 12, 2022

luacmartins commented Oct 21, 2022

luacmartins commented Oct 31, 2022

mvtglobally commented Nov 3, 2022

luacmartins commented Nov 3, 2022 • edited Loading

JmillsExpensify commented Nov 3, 2022

JmillsExpensify commented Nov 6, 2022

luacmartins commented Nov 7, 2022

luacmartins commented Nov 7, 2022

JmillsExpensify commented Nov 8, 2022

luacmartins commented Nov 3, 2022 •

edited

Loading