Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing code from main into staging branch #10995

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Sep 14, 2022

Details

This merges the changes between main and staging into staging, in order to add code from #10935 that should be on the staging branch, but isn't.

The changes are obtained with:

git diff staging..main > staging.diff
git checkout staging
git checkout -b francois-fixStaging
git apply staging.diff

Tests

N/A

PR Review Checklist

N/A

@francoisl francoisl self-assigned this Sep 14, 2022
@francoisl francoisl marked this pull request as ready for review September 14, 2022 18:13
@francoisl francoisl requested a review from a team as a code owner September 14, 2022 18:13
@francoisl francoisl marked this pull request as draft September 14, 2022 18:14
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team September 14, 2022 18:14
@francoisl francoisl marked this pull request as ready for review September 14, 2022 20:02
@francoisl francoisl merged commit ad279a1 into staging Sep 14, 2022
@francoisl francoisl deleted the francois-fixStaging branch September 14, 2022 20:02
@francoisl
Copy link
Contributor Author

Ignoring contributor and reviewer checklists - this PR doesn't add any new logic, just adds missing code onto the staging branch.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @francoisl in version: 1.2.0-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants