Center loading indicator

[varshamb]

Details

Loading indicator was not in the center of container on page addPersonalBankAccountPage and BankAccountStep .
We made it center using styles.flex1.

Fixed Issues

$ #10362

Tests

Steps for adding Payment method in addPersonalBankAccountPage:

1. Go to settings > Payments > Add payment method
2. Click on bank account
3. Verify that the loading spinner is centered vertically.

Steps for BankAccountStep in Workplace:

1. Settings > Workspace > Connect Bank Account
2. Click on Connect Online with Plaid
3. Verify that the loading spinner is centered vertically.

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

QA Steps

Steps for adding Payment method in addPersonalBankAccountPage:

1. Login to valid account
2. Go to settings > Payments > Add payment method
3. Click on bank account

Steps for BankAccountStep in Workplace:

1. Login to valid account
2. Settings > Workspace > Connect Bank Account
3. Click on Connect Online with Plaid

• Verify that no errors appear in the JS console

Screenshots

Web

addPersonalBankAccountPage:

BankAccountStep:

Mobile Web

addPersonalBankAccountPage:

WhatsApp.Video.2022-09-05.at.23.05.27.mp4

BankAccountStep:

WhatsApp.Video.2022-09-08.at.22.43.33.mp4

Desktop

addPersonalBankAccountPage:

BankAccountStep:

iOS

addPersonalBankAccountPage:

WhatsApp.Video.2022-09-05.at.23.08.37.mp4

BankAccountStep:

WhatsApp.Video.2022-09-07.at.22.32.33.mp4

Android

addPersonalBankAccountPage:

BankAccountStep:

[Santhosh-Sellavel]

Also, the same issue could occur when adding a bank account via workspace. It should be handled there too!

Can you handle this also!

[varshamb]

Also, the same issue could occur when adding a bank account via workspace. It should be handled there too!

Can you handle this also!

Yes sure, please suggest the page for adding a bank account via workspace. I am not getting an option to add a bank account in my workspace.

[Santhosh-Sellavel]

Find usages of AddPlaidBankAccount @varshamb

[varshamb]

@Santhosh-Sellavel Done.

[jasperhuangg]

@Santhosh-Sellavel Done.

@varshamb Do you mind updating the screenshots to include both the updated views? Thanks!

[varshamb]

@jasperhuangg Done.

[jasperhuangg]

@jasperhuangg Done.

@varshamb
Thanks! Looks like a few of your screenshots are slightly cut-off and don't display the indicator as centered. I'm checking out your PR now and verifying that everything looks good on my end, but please update those screenshots so that they display the loading indicator as centered vertically/horizontally, since that's what the issue calls for.

[varshamb]

@jasperhuangg updated!

[Santhosh-Sellavel]

@varshamb Still web & desktop videos are not updated, can you update them properly?

[Santhosh-Sellavel]

Take this PR as an example, nothing from the app screen is cut off.

[varshamb]

@Santhosh-Sellavel Is it really needed to update those screen shots, we used styles.flex1 on both pages, the screens which I have attached are slightly cropped from the bottom.

cc: @jasperhuangg

[Santhosh-Sellavel]

@Santhosh-Sellavel Is it really needed to update those screen shots, we used styles.flex1 on both pages, the screens which I have attached are slightly cropped from the bottom.

cc: @jasperhuangg

Actually, that's what @jasperhuangg has asked here to update.

@varshamb
Thanks! Looks like a few of your screenshots are slightly cut-off and don't display the indicator as centered. I'm checking out your PR now and verifying that everything looks good on my end, but please update those screenshots so that they display the loading indicator as centered vertically/horizontally, since that's what the issue calls for.

At least the RHN should be completely visible to ensure it's working fine on both platforms!

[varshamb]

@Santhosh-Sellavel updated.

[Santhosh-Sellavel]

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

C+ Reviewed
🎀 👀 🎀

[Santhosh-Sellavel]

@varshamb

Thanks for updating, mostly looks good just a couple more things.

Can you update the test steps for workspace flow too?

Workspace Flow

Settings -> Workspace -> Connect Bank Account

Should be added in both Tests & QA Tests Section!

[varshamb]

@Santhosh-Sellavel Thanks for your inputs.
Both the 'Tests' & 'QA Tests' has been updated.

[jasperhuangg]

Hey @varshamb thanks for updating those screenshots! I know it's tedious but it's important that we have a correct log of everything that was fixed in the PR.

I also updated your testing steps to include a third step:

3. Verify that the loading spinner is centered vertically.

It's important that you list specifically what to check, this saves time for the QAer since they don't need to read through the issue/PR description to get context.

Overall looks good to me I am approving 👍

[Santhosh-Sellavel]

@jasperhuangg LGTM

[melvin-bot]

@jasperhuangg looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[francoisl]

🚀 Cherry-picked to staging by @francoisl in version: 1.2.0-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

---

Note: we had a conflict on the staging branch which ended up needing to be manually fixed, so this PR doesn't automatically appear in the diff between production and staging - so I'm manually adding the note that it was CPed to staging here.

[OSBotify]

🚀 Deployed to staging by @jasperhuangg in version: 1.2.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅