[HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to setting > profile > Add phone number
2. click on password
3. check send validation button

Expected Result:

Send validation button should not be hidden

Actual Result:

Send validation button is hidden

Platform:

• Android

Version Number: 1.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43995119/190951528-cf5f7ee0-d6e4-43f6-8f4f-3c38f89d6ab7.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661685271625409

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @davidcardoza (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[davidcardoza]

I can't reproduce on mobile because I am running on iOS. The workflow looks like fine on iOS though. Either way, what's shown on Android should mirror what's shown in iOS

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@cead22 Eep! 4 days overdue now. Issues have feelings too...

[cead22]

This is by design. The button should be disabled because the password hasn't been entered

[cead22]

@davidcardoza if you don't understand the issue or can't reproduce it, ask for clarification before assigning to engineering, or simply close the issue

[gadhiyamanan]

@cead22 in android, when you click on a phone number user can see the button but when you click on the password keyboard will hidden

[cead22]

@gadhiyamanan can you double check if when you click password and the button appears hidden, if you can scroll down and see the button? I think it's possible the button isn't hidden, but rather, the keyboard we show for the password is taller than the one we show for the phone number, and it's covering the button, but the button isn't really disappearing.

If you can confirm the button is actually gone and you can't scroll down and see it, please reopen this issue

[gadhiyamanan]

@cead22 not able to scroll down, first I need to close the keyboard

the button disappears only for the password field and is reproducible only on android

[melvin-bot]

Triggered auto assignment to @luacmartins (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

@cead22 I think an external contributor can work on fixing this bug. Would you be against removing the demolition label and making this external?

[cead22]

Not at all, go for it

[JmillsExpensify]

Pulling from the Slack discussion, I wanted to clarify that the next steps are:

• @tgolen has been added to this issue to help review the PR
• @0xmiroslav has an approved proposal and is now assigned to this issue.

Let's get that PR merged in 3 days! As a reminder that triggers a 50% bonus.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[JmillsExpensify]

Agree with @0xmiroslav this isn't the regression.

[JmillsExpensify]

Alright, PR is merged and already on production. This qualifies for 50% bonus.

@tgolen @pecanoro Mind helping clarify what's going on there? We need to align on what the regression period officially started and ended.

Coming back to the payouts, this is where we're at:

• Contributor: @0xmiroslav $3,000 (incl. 50% bonus)
• Contributor+: @Santhosh-Sellavel $3,000 (incl. 50% bonus)
• Issue reporter: @gadhiyamanan $250

Upwork job is here. Can all individuals above please apply so you can be hired and paid out when the time comes?

[JmillsExpensify]

Reminder for myself: Still need to come back to the regression test evaluation.

[pecanoro]

@JmillsExpensify The PR hit production yesterday, so I am assuming the regression period starts from that moment.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix android keyboard issue #13106

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @tgolen / @pecanoro] The PR that introduced the bug has been identified. Link to the PR: Use native KeyboardAvoidingView component everywhere #11586
• [@Santhosh-Sellavel / @tgolen / @pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/11586/files#r1045977954
• [@Santhosh-Sellavel / @tgolen / @pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01SKUP7QR0/p1670859389491609
• [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[JmillsExpensify]

@pecanoro Thanks! Looks like we were slightly ahead of the curve.

[JmillsExpensify]

@Santhosh-Sellavel @gadhiyamanan Can both of you please make sure to apply for the Upwork job. The correct amounts are here.

Separately, @Santhosh-Sellavel @pecanoro it would be good to get a head start on the checklist above. Can you check the boxes please and confirm we're good there. I'll separately get started on the regression tests.

Thanks all!

[gadhiyamanan]

Applied, thanks

[pecanoro]

@Santhosh-Sellavel @tgolen We could link the PR when the KeyboardAvoidingView behavior for Android was introduced but I think we always had keyboard issues and this wasn't a new bug but inconsistent behavior of the keyboard itself, right? Unless I am missing something of course.

[Santhosh-Sellavel]

Yeah this existed even before that PR #11586

[JmillsExpensify]

Ok cool, that sounds right to me. Ya'll mind checking off the above. I'll circle back on the regression test tomorrow when I settle up with everyone.

[JmillsExpensify]

Everyone is paid out at this point. Updating the title to clarity I need to create the regression test issue. Won't be able to get to that today.

[JmillsExpensify]

@Santhosh-Sellavel @pecanoro @tgolen Regression test is a work in progress and linked to the larger set of keyboard tests we'll kick off as part of the KAV initiative. Accordingly, I've marked the regression test off above. I'm OOO this week, so can you all fill out your part of the BugZero checklist above and then close this issue out? Thank you!

[tgolen]

BZ checklist is done so I will close this out.

[mallenexpensify]

Coming from #10483 (comment)
We've decided to issue @0xmiroslav a bonus of $1000 because their PR fixed many bugs. I have made the payment on the job https://www.upwork.com/jobs/~015814913e9779f5c9