Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-01-25 #14537

Closed
19 tasks done
OSBotify opened this issue Jan 25, 2023 · 5 comments
Closed
19 tasks done

Deploy Checklist: New Expensify 2023-01-25 #14537

OSBotify opened this issue Jan 25, 2023 · 5 comments
Assignees
@luacmartins @applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 25, 2023 •
edited by luacmartins
Loading

Release Version: 1.2.59-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 25, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 25, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.59-1 🚀

@luacmartins luacmartins self-assigned this Jan 25, 2023
@luacmartins luacmartins added the Daily KSv2 label Jan 25, 2023
@mountiny
Copy link
Contributor

Checking #14548 off as we had confirmed the backend change has resolved the issue.

@mvtglobally
Copy link

mvtglobally commented Jan 26, 2023 •
edited
Loading

@roryabraham @luacmartins Regression is completed

#13118 Is failing #14590. Issue is not repro in PROD, but introduced as new feature. We are not sure if this should be a blocker or no.
#14409 is failing #14565 & #14593

@luacmartins
Copy link
Contributor

Checking off #14409, since both #14565 & #14593 are expected behabiors.

I'm looking at #14590 now.

@luacmartins
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@luacmartins @mountiny @applausebot @mvtglobally @OSBotify