Chat - Unexpected error when completing payment request. #14571

kbecciv · 2023-01-25T21:51:45Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com
Login with gmail account
Account A requests money from account B
Account B complete the requested payment.

Expected Result:

No error message should be displayed after complete payment.

Actual Result:

Unexpected error message occurs after payment is completed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5911777_payment_error.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify · 2023-01-25T21:53:25Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

kbecciv · 2023-01-25T21:53:39Z

Could be the same root of cause #14548

luacmartins · 2023-01-25T22:04:00Z

That does seem to be related. It should be fixed now though. Can you please retest?

mvtglobally · 2023-01-25T22:04:28Z

@luacmartins
I am seeing this on Desktop now.. Related?
Also can you confirm what version should we retest?

Recording.584.mp4

Luke9389 · 2023-01-25T22:23:53Z

Reproducing locally with logs to see if this is a back end issue.

mvtglobally · 2023-01-25T22:26:45Z

@luacmartins @Luke9389 I dont see anything in console, but in case you need logs, this is account used on my side applausetester++1014mvt@applause.expensifail.com

Luke9389 · 2023-01-25T22:32:06Z

Thanks for that info @mvtglobally.

@luacmartins these are the logs I'm getting

2023-01-25T22:30:10.654318+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [hmmm] Throw ExpException - 0f7b9e631cada45edbf331aaf860f4a5 ~~ message: '402 Missing clientID' exceptionMessage: 'Auth PayMoneyRequest returned an error' exceptionFile: '/vagrant/Web-Expensify/lib/Auth.php' exceptionLine: '121' exceptionCode: '402'
2023-01-25T22:30:10.654443+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] StackTrace start
2023-01-25T22:30:10.654559+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 0/3. file '/vagrant/Web-Expensify/lib/Auth.php' function '_standardResponseHandler' line '6773'
2023-01-25T22:30:10.654649+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 1/3. file '/vagrant/Web-Expensify/lib/ReportAPI.php' function 'payMoneyRequest' line '4076'
2023-01-25T22:30:10.654685+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 2/3. file '/vagrant/Web-Expensify/lib/ReportAPI.php' function 'payMoneyRequest' line '4131'
2023-01-25T22:30:10.654713+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 3/3. file '/vagrant/Web-Expensify/api.php' function 'payMoneyRequestElsewhere' line '2843'
2023-01-25T22:30:10.654776+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] StackTrace end
2023-01-25T22:30:10.655258+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [warn] [OOPS!] API Threw: Auth PayMoneyRequest returned an error ExpException - 0f7b9e631cada45edbf331aaf860f4a5 ~~ message: '402 Missing clientID' exceptionMessage: 'Auth PayMoneyRequest returned an error' exceptionFile: '/vagrant/Web-Expensify/lib/Auth.php' exceptionLine: '121' exceptionCode: '402'
2023-01-25T22:30:10.655377+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [dbug] _send( expensidev2004.web.log.warn:1|c )
2023-01-25T22:30:10.671081+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] DB_Analytics - Connecting to database. ~~ attemptNumber: '1' host: '127.0.0.1' dbName: 'analytics'
2023-01-25T22:30:10.699538+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [benchmark] Stop timing 'DB Connect DB_Analytics' (took 0.0302 seconds)
2023-01-25T22:30:10.699621+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [dbug] DB_Analytics - INSERT INTO serverErrors( created, uuid, message, email, accountID, requestID, source ) VALUES( '2023-01-25 22:30:10', 'WARN_0e572d904e298e98b87914c754dd74f1', '[OOPS!] API Threw: Auth PayMoneyRequest returned an error ExpException - 0f7b9e631cada45edbf331aaf860f4a5', 'spider@animals.com', null, '8FwZ2U', 'api' );
2023-01-25T22:30:10.699659+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] Benchmark started:DB_Analytics - Executing query
2023-01-25T22:30:10.749430+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] Benchmark finished:DB_Analytics - Executing query ~~ time: '0.049474000930786'
2023-01-25T22:30:10.761684+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [push] Push_Service - Sending event ~~ channel: '[0: 'public-debugserverid5e9f713e07e22-7c516c908f6d4b57abbed4262e48a5ae']' eventName: 'debug' eventData: '{"level":"warn","message":"[OOPS!] API Threw: Auth PayMoneyRequest returned an error ExpException - 0f7b9e631cada45edbf331aaf860f4a5 ~~ message: '402 Missing clientID' exceptionMessage: 'Auth PayMoneyRequest returned an error' exceptionFile: '\/vagrant\/Web-Expensify\/lib\/Auth.php' exceptionLine: '121' exceptionCode: '402'"}'
2023-01-25T22:30:10.761779+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] StackTrace start
2023-01-25T22:30:10.761810+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 0/3. file '/vagrant/Web-Expensify/lib/Auth.php' function '_standardResponseHandler' line '6773'
2023-01-25T22:30:10.761865+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 1/3. file '/vagrant/Web-Expensify/lib/ReportAPI.php' function 'payMoneyRequest' line '4076'
2023-01-25T22:30:10.761927+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 2/3. file '/vagrant/Web-Expensify/lib/ReportAPI.php' function 'payMoneyRequest' line '4131'
2023-01-25T22:30:10.761952+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] 3/3. file '/vagrant/Web-Expensify/api.php' function 'payMoneyRequestElsewhere' line '2843'
2023-01-25T22:30:10.761964+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] [trace] StackTrace end
2023-01-25T22:30:10.762751+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] StoreUtils - Clearing all the stores.
2023-01-25T22:30:10.763715+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] TransactionStore cache fully cleared
2023-01-25T22:30:10.763903+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] ReportStore cache cleared
2023-01-25T22:30:10.764481+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] NVPStore - clear cache
2023-01-25T22:30:10.764593+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] NVPStore - clear cache
2023-01-25T22:30:10.767834+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] SharedInNVPStore - clear cache
2023-01-25T22:30:10.769021+00:00 expensidev2004 php-fpm: 8FwZ2U /api.php spider@animals.com !ecash1.2.59-1! ?api? [info] ReportDuplicatedTransactionsStore - Cache cleared

Looks like we're failing to send a clientID with that request.

mvtglobally · 2023-01-25T22:36:28Z

@Luke9389 Should we log a different issue for this or you want to track here ?

Luke9389 · 2023-01-25T22:38:39Z

Let's track this one here until they're able to get some logs on the other issue.

I'm not convinced they're the same root cause yet.

roryabraham · 2023-01-25T22:51:18Z

Looks like we're failing to send a clientID with that request.

@Luke9389 I think this should have been fixed by https://github.com/Expensify/Auth/pull/7440, – clientID was made optional in PayMoneyRequest. Since that's been deployed, can we re-test this?

mvtglobally · 2023-01-25T22:54:53Z

@roryabraham I am seeing it right now on this account across all requests. It seem to be specific to account. Since it's the same build, anything else I need to do to verify it?

Luke9389 · 2023-01-25T23:16:13Z

@roryabraham that sure does seem related. @mvtglobally are you testing with a new payment request each time?

mvtglobally · 2023-01-25T23:44:00Z

@Luke9389 Yes, Tried a brand new request from an account I didn't have requests from before just now. Tried to pay with applausetester++1014mvt@applause.expensifail.com and get the same blank screen
Maybe you can double check logs

luacmartins · 2023-01-26T00:06:24Z

I'm unable to reproduce this issue on any platform

desktop.mov

Luke9389 · 2023-01-26T00:15:57Z

Interesting @luacmartins, I don't see an option for you that says "I'll settle up elsewhere". Not sure why that's the case.

I'm also seeing quite a few of these errors in the logs from the past hour or so.
https://www.expensify.com/_devportal/tools/logSearch/#sort=desc&size=10000&query=blob%3A%22402%20Missing%20clientID%22%20AND%20timestamp%3A%5B2023-01-25T00%3A00%20TO%202023-01-26T23%3A59%5D

@roryabraham is it possible that PR didn't fix this after all? Or maybe we need a front end change as well?

luacmartins · 2023-01-26T00:19:38Z

@Luke9389 you can see that at around 0:19.

I couldn't find anything out of the ordinary in the logs for applausetester++1014mvt@applause.expensifail.com

The logs Luke shared above do look suspicious

luacmartins · 2023-01-26T00:22:16Z

Actually @Luke9389 those logs are from earlier today, all before 2023-01-25 19:58 UTC. Auth deploy was done at around 2023-01-25 21:06 UTC and I can't find any more instances of that error in the logs after that time

Luke9389 · 2023-01-26T00:28:18Z

Oh gotcha. Interesting. I just saw your ping in the thread so we'll discuss further there.

thienlnam · 2023-01-26T00:37:20Z

https://expensify.slack.com/archives/C07J32337/p1674693393153289?thread_ts=1674692873.600099&cid=C07J32337

Resolved with auth deploy

Luke9389 · 2023-01-26T00:38:52Z

Thanks @thienlnam. It is true that the unexpected error bug that we saw in the original description has been resolved.

Later in the thread we began discussing a blank screen, which may or may not be related.
@mvtglobally, can you open a new issue for the blank screen problem with reproduction steps?

We feel it's best to separate these two issues.

mvtglobally · 2023-01-26T00:48:40Z

sure. I will ask team if they can repro and log with the steps

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 25, 2023

melvin-bot bot locked and limited conversation to collaborators Jan 25, 2023

OSBotify mentioned this issue Jan 25, 2023

Deploy Checklist: New Expensify 2023-01-25 #14537

Closed

19 tasks

github-actions bot added Engineering Hourly KSv2 labels Jan 25, 2023

melvin-bot bot assigned Luke9389 Jan 25, 2023

thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jan 26, 2023

thienlnam closed this as completed Jan 26, 2023

Expensify unlocked this conversation Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chat - Unexpected error when completing payment request. #14571

Chat - Unexpected error when completing payment request. #14571

kbecciv commented Jan 25, 2023 •

edited

Loading

OSBotify commented Jan 25, 2023

kbecciv commented Jan 25, 2023

luacmartins commented Jan 25, 2023

mvtglobally commented Jan 25, 2023 •

edited

Loading

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

roryabraham commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023 •

edited

Loading

luacmartins commented Jan 26, 2023

Luke9389 commented Jan 26, 2023

luacmartins commented Jan 26, 2023

luacmartins commented Jan 26, 2023 •

edited

Loading

Luke9389 commented Jan 26, 2023

thienlnam commented Jan 26, 2023

Luke9389 commented Jan 26, 2023

mvtglobally commented Jan 26, 2023

Chat - Unexpected error when completing payment request. #14571

Chat - Unexpected error when completing payment request. #14571

Comments

kbecciv commented Jan 25, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

OSBotify commented Jan 25, 2023

kbecciv commented Jan 25, 2023

luacmartins commented Jan 25, 2023

mvtglobally commented Jan 25, 2023 • edited Loading

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

roryabraham commented Jan 25, 2023

mvtglobally commented Jan 25, 2023

Luke9389 commented Jan 25, 2023

mvtglobally commented Jan 25, 2023 • edited Loading

luacmartins commented Jan 26, 2023

Luke9389 commented Jan 26, 2023

luacmartins commented Jan 26, 2023

luacmartins commented Jan 26, 2023 • edited Loading

Luke9389 commented Jan 26, 2023

thienlnam commented Jan 26, 2023

Luke9389 commented Jan 26, 2023

mvtglobally commented Jan 26, 2023

kbecciv commented Jan 25, 2023 •

edited

Loading

mvtglobally commented Jan 25, 2023 •

edited

Loading

mvtglobally commented Jan 25, 2023 •

edited

Loading

luacmartins commented Jan 26, 2023 •

edited

Loading